fix: display months in year view in horizontal mode in a scrollview#1057
Open
rros wants to merge 1 commit intoFossifyOrg:mainfrom
Open
fix: display months in year view in horizontal mode in a scrollview#1057rros wants to merge 1 commit intoFossifyOrg:mainfrom
rros wants to merge 1 commit intoFossifyOrg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
I changed the layout of the fragment_year layout to have a scrollview for the months. Because the SmallMonthView doesn't have a size of itself, I added an onMeasure method to calculate the desired size of the view. This combined with choosing a good combination of wrap_content and match_parent fixes the layout of this view in horizontal mode.
Some additional considerations:
Tests performed
Before & after preview
Before:

After:
Screen_recording_20260214_233544.webm
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).