Skip to content

Parade no errror #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnAZoidberg merged 2 commits into from
Nov 20, 2025
Merged

Parade no errror #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be2cb7
--versions: Don't show parade error unnecessarily:
JohnAZoidberg Nov 20, 2025
0a07214
--versions: Don't print baseboard version error
JohnAZoidberg Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions framework_lib/src/commandline/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,8 +705,13 @@ fn print_versions(ec: &CrosEc) {
);
}
_err => {
println!("Parade Retimers");
println!(" Unknown");
// Only Framework 16 has dGPU support (which has Parade Retimer)
if smbios::get_platform().and_then(Platform::which_family)
== Some(PlatformFamily::Framework16)
{
println!("Parade Retimers");
println!(" Unknown");
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion framework_lib/src/smbios.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ pub fn get_baseboard_version() -> Option<ConfigDigit0> {
{
return version_config;
} else {
error!(" Invalid BaseBoard Version: {}'", version);
debug!(" Invalid BaseBoard Version: {}'", version);
}
}
}
Expand Down