Conversation
picture-options here has never taken effect. phosh ships 00_mobi.Phosh.gschema.override with a desktop scoped [org.gnome.desktop.screensaver:Phosh] picture-options='none' and a desktop scoped default beats a generic one whatever the filenames sort like, so the plain [org.gnome.desktop.screensaver] section in this file is silently ignored on FuriOS. Verified by compiling both override files into a throwaway schema directory: under XDG_CURRENT_DESKTOP=Phosh the key resolves to 'none', and only under GNOME to the 'zoom' set here. Scoping the section the same way lets file order decide, and 10 sorts after 00. Signed-off-by: wayne <wayne@furilabs.com>
'zoom' covers the screen and crops whatever does not fit. That suits a wallpaper chosen for the shape of the screen; it suits a phone badly, because the pictures people actually use are photographs they took, and a 4:3 photograph on a 20:9 screen loses most of its width to a crop it has no say over. 'scaled' keeps all of the picture. Both keys, since the lock screen has a wallpaper of its own. Signed-off-by: wayne <wayne@furilabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the wallpaper
picture-optionsdefault here out of FuriLabs/phosh#5,where it did not belong.
Two commits, because they are two separate things.
1.
debian: scope the screensaver default to Phosh so it appliesThe
picture-optionsalready in this file has never taken effect onFuriOS. phosh ships a desktop-scoped default of its own:
and a desktop-scoped default beats a generic one whatever the filenames sort
like, so the plain
[org.gnome.desktop.screensaver]section here is silentlyignored under Phosh.
Verified rather than inferred, by compiling
00_mobi.Phosh.gschema.overrideand this file into a throwaway schema directory and reading the key back:
Scoping our section the same way lets file order decide, and
10_sorts after00_. This commit changes no value — it only makes the existing'zoom'actually reach the lock screen for the first time.
2.
debian: default to fitting the whole picture'zoom'covers the screen and crops whatever does not fit. That suits awallpaper chosen for the shape of the screen; it suits a phone badly, because
the pictures people actually use are photographs they took, and a 4:3
photograph on a 20:9 screen loses most of its width to a crop it has no say
over.
'scaled'keeps all of the picture.Both keys, since the lock screen has a wallpaper of its own.
The two are split so the first can be taken and the second dropped if you
disagree about
scaled— the bug fix does not depend on the value change.