Touch point markers, switchable while the compositor runs - #2
Open
wayne-tbl wants to merge 3 commits into
Open
Conversation
The flags are otherwise parsed once from PHOC_DEBUG at startup, which is no use to anything that wants one for a moment and off again afterwards. Signed-off-by: wayne <wayne@furilabs.com>
wayne-tbl
force-pushed
the
screen-capture
branch
from
August 18, 2026 11:18
6bfc0aa to
86da4ff
Compare
Approximated with horizontal slices inside the existing render pass rather than a shader, and shrunk to a resting size shortly after the finger goes down so a recording shows the tap rather than a static dot. All of it sits behind IS_FURIOS, so upstream's color_hsv_to_rgb() and render_touch_point_cb() stay in the file unchanged and building them back is a one-line change. Both settings of the switch compile warning free. Signed-off-by: wayne <wayne@furilabs.com>
Lets a screen recording show what was pressed and put the markers away afterwards, without restarting the compositor. The markers are drawn from the render pass, so nothing appears or clears until a frame is asked for. Signed-off-by: wayne <wayne@furilabs.com>
wayne-tbl
force-pushed
the
screen-capture
branch
from
August 28, 2026 06:30
86da4ff to
2a3da07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touch point markers a screen recording can show, switchable while the
compositor is running.
Updated at review request (21 Aug): everything this fork changes about the
markers is behind
IS_FURIOS— see below.server: allow toggling debug flags at runtime— the flags are otherwiseparsed once from
PHOC_DEBUGat startup, which is no use to anything thatwants one for a moment and off again afterwards.
renderer: draw touch points as discs— approximated with horizontal slicesinside the existing render pass rather than a shader, and shrunk to a resting
size shortly after the finger goes down, so a recording shows the tap rather
than a static dot. All of it behind
IS_FURIOS.desktop: add a touch-points gsetting— lets a recording show what waspressed and put the markers away afterwards without restarting the
compositor. Nothing appears or clears until a frame is asked for, since the
markers are drawn from the render pass.
IS_FURIOS#define IS_FURIOS 1sits by the includes insrc/render.c, following thepattern of FuriLabs/phosh
f559f26b.color_hsv_to_rgb()and upstream'srender_touch_point_cb()stay in the file byte-identical toforky,built under
#else; ours build under#if IS_FURIOS. Setting it to 0 buildsupstream's markers back.
phoc_box_from_touch_point()is unchanged and sharedby both.
The diff to
render.cis +91 lines and 0 deletions againstforky.One upstream line does change:
TOUCH_POINT_SIZEbecomes conditional, 60 forthe discs and upstream's 20 otherwise.
damage_touch_point_cb()sizes itsdamage box from it, so leaving it at 20 would damage less than the discs draw.
Both settings of the switch compile with no warnings, and
meson testis17/17 including
check-indent.Pairs with the screen recorder quick setting in phosh
(FuriLabs/phosh, branch
screen-capture), whose Show Touches option writesthis
touch-pointskey. Neither breaks without the other — the option issimply inert until phoc has the key.
3 commits, off
forky. Tested on an FLX1.