feat: give group participants room, search and copy - #101
Merged
Conversation
Alaraajavamma
force-pushed
the
feature/forky/feat-participant-actions
branch
3 times, most recently
from
August 22, 2026 21:00
fd66843 to
8275f9b
Compare
A participant card put the name, the number and three buttons in one row, so the name was capped at fifteen characters to make space. The text gets the full width now and the buttons sit under it, which also makes room for two actions the call details already had and the group sheet did not: searching the sender online and copying the number. Both work for alphanumeric senders too, where searching is at its most useful and calling is impossible. The card carries no margins of its own, because the app's card style already pads twelve pixels and every margin added here stacked on top of it. The search buttons made the settings dishonest, so they are split by what they govern. The switch that claimed to control the search button in the in-call window and call history only ever controlled the in-call one, and it hid the engine choice with it, leaving the engine unreachable from the surfaces that used it regardless of the switch. The engine moved to its own Number Lookup category, visible from the calls and the messages app alike, because the buttons it serves are in both while the screening options remain call things. Buttons inside menus the user opens are not gated at all: a feature behind a switch is a feature nobody finds, and the in-call button keeps its opt-in because it is the one that appears uninvited. The participants panel and the search bar slide in from the chat header rather than floating over the list, so nothing dismissed them; a tap in the conversation now does, left unclaimed so it still does whatever it was aimed at. A search with text in it stays, since tapping the filtered list is how a result is reached.
Alaraajavamma
force-pushed
the
feature/forky/feat-participant-actions
branch
from
August 23, 2026 16:49
8275f9b to
928c14f
Compare
Alaraajavamma
marked this pull request as ready for review
August 23, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A participant card put the name, the number and three buttons in one
row, so the name was capped at fifteen characters to make space. The
text gets the full width now and the buttons sit under it, which also
makes room for two actions the call details already had and the group
sheet did not: searching the sender online and copying the number.
Both work for alphanumeric senders too, where searching is at its most
useful and calling is impossible. The card carries no margins of its
own, because the app's card style already pads twelve pixels and every
margin added here stacked on top of it.
The search buttons made the settings dishonest, so they are split by
what they govern. The switch that claimed to control the search button
in the in-call window and call history only ever controlled the
in-call one, and it hid the engine choice with it, leaving the engine
unreachable from the surfaces that used it regardless of the switch.
The engine moved to its own Number Lookup category, visible from the
calls and the messages app alike, because the buttons it serves are in
both while the screening options remain call things. Buttons inside
menus the user opens are not gated at all: a feature behind a switch
is a feature nobody finds, and the in-call button keeps its opt-in
because it is the one that appears uninvited.
The participants panel and the search bar slide in from the chat
header rather than floating over the list, so nothing dismissed them;
a tap in the conversation now does, left unclaimed so it still does
whatever it was aimed at. A search with text in it stays, since
tapping the filtered list is how a result is reached.