fix: aim toasts at the sheet they answer from - #106
Open
Alaraajavamma wants to merge 1 commit into
Open
Conversation
Alaraajavamma
force-pushed
the
feature/forky/fix-toasts-over-sheets
branch
3 times, most recently
from
August 23, 2026 21:56
aeb96fe to
acb16a2
Compare
the toast overlay sits under an open sheet, so a toast raised while one was open answered to nobody. the sheet content rides in its own overlay now and the surface picker prefers it, same as it already did for dialogs. re-parenting the window's host overlay instead stopped every sheet from opening at all.
Alaraajavamma
force-pushed
the
feature/forky/fix-toasts-over-sheets
branch
from
August 23, 2026 22:25
acb16a2 to
4bd8050
Compare
Alaraajavamma
changed the title
Alaraajavamma
marked this pull request as ready for review
August 23, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the toast overlay sits under an open sheet, so a toast raised while
one was open answered to nobody. the sheet content rides in its own
overlay now and the surface picker prefers it, same as it already did
for dialogs. re-parenting the window's host overlay instead stopped
every sheet from opening at all.