fix: show an MMS as delivered when the network says so - #79
Draft
Alaraajavamma wants to merge 1 commit into
Draft
Conversation
Alaraajavamma
force-pushed
the
feature/forky/fix-mms-delivered
branch
3 times, most recently
from
August 14, 2026 21:15
2efc6fc to
fcc3729
Compare
Alaraajavamma
force-pushed
the
feature/forky/fix-mms-delivered
branch
4 times, most recently
from
August 23, 2026 21:56
f2f8971 to
d6ce025
Compare
mmsd only ever reported a message as sent, so a delivery had nowhere to arrive. remember sent messages until the network answers and only take actual deliveries: expired or rejected still means sent, and the bubble already draws delivered from the status the SMS side writes.
Alaraajavamma
force-pushed
the
feature/forky/fix-mms-delivered
branch
from
August 23, 2026 22:25
d6ce025 to
fb17bbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon that carries MMS only ever reports a message as sent, so nothing here looks at any other status and a delivery has nowhere to arrive.
A delivery says nothing about being in flight (the send resolved long before) so the message is remembered separately until the network answers or the list ages it out. Only a delivery is taken: a message that expired or was rejected was still sent.
The bubble needs no change; it already draws delivered from the same status the SMS side writes. Draft because it is inert until mmsd4ofono reports deliveries.