fix: keep the reason a call ended when we are the ones ending it - #98
Merged
Conversation
Calls the user hung up were logged with no reason at all, so the history could not tell them apart from calls that simply stopped. Two things caused it. This modem answers Hangup on an answered call with an error while hanging it up anyway, so the error cannot be read as the call still being there; the call is given a moment to disappear on its own and dropped if it has not. And the reason is recorded when the user asks rather than when the modem replies, because the asking is what makes it local. Whatever the modem reports afterwards replaces it, so a call the other end happened to drop at the same moment still says so. Hanging up everything at once is marked the same way. It is the same request with more calls in it, and the reason was being lost on exactly the paths that end a conference or clean up after a lost window.
Alaraajavamma
force-pushed
the
feature/forky/fix-hangup-loses-reason
branch
from
August 23, 2026 16:49
fd07bb0 to
924df0a
Compare
Alaraajavamma
changed the title
Alaraajavamma
marked this pull request as ready for review
August 23, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls the user hung up were logged with no reason at all, so the
history could not tell them apart from calls that simply stopped.
Two things caused it. This modem answers Hangup on an answered call
with an error while hanging it up anyway, so the error cannot be read
as the call still being there; the call is given a moment to disappear
on its own and dropped if it has not. And the reason is recorded when
the user asks rather than when the modem replies, because the asking is
what makes it local. Whatever the modem reports afterwards replaces it,
so a call the other end happened to drop at the same moment still says
so.
Hanging up everything at once is marked the same way. It is the same
request with more calls in it, and the reason was being lost on exactly
the paths that end a conference or clean up after a lost window.