Repository navigation
chore: Add prek to testing workflows and frontend files - #607
Merged
Merged
Conversation
tykeal
reviewed
May 13, 2026
tykeal
left a comment
Collaborator
There was a problem hiding this comment.
I've got more comprehensive workflows and pre-commit config with Rental Control if you want me to try and port them in...
…ncies, disable method-assign)
- Fix mypy issues in coordinator and tests - Fix markdown linting in PROVIDERS.md - Apply ruff formatting to test_base.py - Add yarn install to prek CI jobs for tsc resolution - Pin all GitHub actions to SHAs
- Corrected HACS and Hassfest action SHAs - Fixed invalid ignoreDeprecations value in tsconfig.json
- Update moduleResolution to 'bundler' to resolve vite/vitest types - Cast mock config to any in view-strategy.test.ts
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage ? 87.44%
=======================================
Files ? 39
Lines ? 3814
Branches ? 30
=======================================
Hits ? 3335
Misses ? 479
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
firstof9
marked this pull request as ready for review
May 13, 2026 14:09
Collaborator
Author
|
I think all the holes are plugged now. |
tykeal
approved these changes
May 14, 2026
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR focuses on stabilizing the
keymasterintegration by addressing critical race conditions during teardown, modernizing the CI/CD pipeline, and resolving long-standing test coverage gaps in both the backend (Python) and frontend (TypeScript) codebases.Changes
🛠️ Backend Stabilization & Cleanup
coordinator.pywhere rapid integration reloads could trigger multiple overlapping deletion attempts. Implemented apending_deletestate guard and ensuredasync_shutdownproperly cancels all active refresh timers.TimerStoreinautolock/store.pyto defensively handle naive datetime strings by explicitly interpreting them as UTC, ensuring consistency with the rest of the integration.coordinator.pyandstore.py.🎨 Lovelace Strategy (Frontend) Improvements
section-strategy.ts(error handling and initialization states).slugify.ts(edge cases and special characters).no-explicit-anyerrors and standardized type casting across the strategy components.🚀 CI/CD & Environment
pre-commitpipeline including:ruff(linting and formatting)mypy(static type checking)codespell(spelling)actionlint(GitHub Actions validation)eslint&tsc(TypeScript validation)Testing Status
pytest)vitest)