Skip to content

chore: address aislop scan findings (easy) - #658

Merged
tykeal merged 1 commit into
FutureTense:mainfrom
tykeal:chore/aislop-cleanup
Jun 16, 2026
Merged

tykeal merged 1 commit into
FutureTense:mainfrom
tykeal:chore/aislop-cleanup

Conversation

@tykeal

@tykeal tykeal commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Ran aislop scan v0.12.0 on a clean upstream/main checkout.
  • Fixed 67 EASY findings: 17 narrative comments, 49 trivial comments, and 1 swallowed exception.
  • Score improved from 17 → 21; remaining findings are not auto-fixable.

Fixed findings

  • ai-slop/narrative-comment: removed decorative/narrative separators.
  • ai-slop/trivial-comment: removed comments that only repeated the code.
  • ai-slop/swallowed-exception: replaced AttributeError: pass in event state cleanup with debug logging.

Remaining MEDIUM/HARD issues

Validation

  • prek run --all-files
  • pytest tests/ (914 passed)
  • aislop scan --format json after fixes: score 21, 193 remaining findings, 0 fixable

@tykeal
tykeal requested a review from Copilot June 15, 2026 16:23
@github-actions github-actions Bot added the chore Code chores (dependency updates, etc) label Jun 15, 2026

This comment was marked as outdated.

@codecov-commenter

codecov-commenter commented Jun 15, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (cdb4922) to head (1253d27).
⚠️ Report is 182 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   84.14%   92.15%   +8.01%     
==========================================
  Files          10       41      +31     
  Lines         801     4793    +3992     
  Branches        0       30      +30     
==========================================
+ Hits          674     4417    +3743     
- Misses        127      376     +249     
Flag Coverage Δ
python 92.00% <100.00%> (?)
typescript 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment was marked as outdated.

Removed deterministic trivial and narrative comments reported by aislop and replaced the swallowed AttributeError in event state cleanup with debug logging. Rebuilt the generated Lovelace bundle after TypeScript comment cleanup.

Rules cleared:
- ai-slop/narrative-comment: 17 findings
- ai-slop/trivial-comment: 49 findings
- ai-slop/swallowed-exception: 1 finding

aislop score: 17 -> 21.

Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.

@firstof9

Copy link
Copy Markdown
Collaborator

Interesting, I sometimes leave comments like this in hand written code.

@tykeal

tykeal commented Jun 16, 2026 •

Copy link
Copy Markdown
Collaborator Author

I find them a little interesting too. Some of those I might have stuck in if I was hand rolling just to help orient. I'm trying to get us to a place where I can add aislop scanning to the the pre-commit hooks. This is the lowest hanging issues that it raised. See all the issues that I raised about it the harder ones.

@firstof9

Copy link
Copy Markdown
Collaborator

I'm all for the clean up, just found it interesting with these findings. 👍

@tykeal
tykeal merged commit 711a896 into FutureTense:main Jun 16, 2026
10 checks passed
@tykeal
tykeal deleted the chore/aislop-cleanup branch June 16, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Code chores (dependency updates, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants