Repository navigation
chore: address aislop scan findings (easy) - #658
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 84.14% 92.15% +8.01%
==========================================
Files 10 41 +31
Lines 801 4793 +3992
Branches 0 30 +30
==========================================
+ Hits 674 4417 +3743
- Misses 127 376 +249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5f1d5c6 to
6f2a8b7
Compare
Removed deterministic trivial and narrative comments reported by aislop and replaced the swallowed AttributeError in event state cleanup with debug logging. Rebuilt the generated Lovelace bundle after TypeScript comment cleanup. Rules cleared: - ai-slop/narrative-comment: 17 findings - ai-slop/trivial-comment: 49 findings - ai-slop/swallowed-exception: 1 finding aislop score: 17 -> 21. Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6f2a8b7 to
1253d27
Compare
|
Interesting, I sometimes leave comments like this in hand written code. |
|
I find them a little interesting too. Some of those I might have stuck in if I was hand rolling just to help orient. I'm trying to get us to a place where I can add |
|
I'm all for the clean up, just found it interesting with these findings. 👍 |
Summary
aislop scan v0.12.0on a cleanupstream/maincheckout.Fixed findings
ai-slop/narrative-comment: removed decorative/narrative separators.ai-slop/trivial-comment: removed comments that only repeated the code.ai-slop/swallowed-exception: replacedAttributeError: passin event state cleanup with debug logging.Remaining MEDIUM/HARD issues
ai-slop/python-chained-dict-getinproviders/zha.pycomplexity/deep-nestingin coordinator and Zigbee2MQTTsecurity/dependency-audit-skippedinpackage.jsoncomplexity/file-too-largeacross core modulescomplexity/function-too-longacross core flowsai-slop/hallucinated-importacross integration dependenciesai-slop/python-isinstance-ladderin coordinator and Zigbee2MQTTcomplexity/too-many-paramsinlovelace.pyValidation
prek run --all-filespytest tests/(914 passed)aislop scan --format jsonafter fixes: score 21, 193 remaining findings, 0 fixable