Skip to content

chore(deps-dev): bump @rollup/plugin-terser to 1.0.0 - #794

Merged
firstof9 merged 1 commit into
FutureTense:mainfrom
tykeal:bump-rollup-plugin-terser
Sep 14, 2026
Merged

firstof9 merged 1 commit into
FutureTense:mainfrom
tykeal:bump-rollup-plugin-terser

Conversation

@tykeal

@tykeal tykeal commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bump the direct devDependency @rollup/plugin-terser from ^0.4.4 to
^1.0.0 to clear the known audit findings in the JavaScript build tooling.

Before this bump, npm audit reported 2 vulnerabilities: the moderate direct
advisory on @rollup/plugin-terser and the high-severity transitive
serialize-javascript advisory. After the bump, npm audit reports 0
vulnerabilities.

Proposed change

This PR updates only the @rollup/plugin-terser devDependency range in
package.json. The affected packages are build-time minifier tooling only and
are not shipped to users. Version 1.0.0 keeps rollup ^2||^3||^4 peer support,
so the repository's rollup ^4.54.0 dependency remains satisfied.

Local verification used npm install --legacy-peer-deps, npm audit,
npx rollup -c, and npx vitest run. The rollup build succeeded, the emitted
custom_components/keymaster/www/generated/keymaster.js bundle remained
byte-identical to the committed artifact, and all 30 vitest tests passed across
5 files. Dependabot cannot propose this bump automatically because lockfiles are
intentionally gitignored; see #652.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Upgrade @rollup/plugin-terser to clear the high-severity
serialize-javascript advisory and the moderate advisory on
@rollup/plugin-terser itself, bringing npm audit to 0 vulnerabilities.

Both affected packages are dev-only build-time minifier dependencies and
are not shipped to users. Version 1.0.0 keeps rollup ^2||^3||^4 peer
support, so the repository's rollup ^4.54.0 dependency remains
satisfied.

The emitted bundle remains byte-identical to the committed artifact, and
the existing vitest suite is unaffected. Dependabot cannot propose this
bump because lockfiles are intentionally gitignored, as tracked in
FutureTense#652.

Assisted-by: GitHub Copilot CLI 1.0.83 (Claude Opus 5, model claude-opus-5)
Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
@github-actions github-actions Bot added the chore Code chores (dependency updates, etc) label Sep 13, 2026
@tykeal
tykeal requested a lite review from Copilot September 13, 2026 21:15
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (cdb4922) to head (bb0d5e1).
⚠️ Report is 361 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #794       +/-   ##
===========================================
+ Coverage   84.14%   97.07%   +12.92%     
===========================================
  Files          10       50       +40     
  Lines         801     6010     +5209     
  Branches        0       30       +30     
===========================================
+ Hits          674     5834     +5160     
- Misses        127      176       +49     
Flag Coverage Δ
typescript 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments; the dependency update addresses vulnerabilities without changing shipped functionality.

Pull request overview

Updates @rollup/plugin-terser from ^0.4.4 to ^1.0.0 to address dependency vulnerabilities while retaining Rollup compatibility.

Changes:

  • Bumps the direct development dependency.
  • Preserves the existing build tooling configuration.
File summaries
File Summary
package.json Updates the Rollup Terser plugin dependency.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@firstof9
firstof9 merged commit 3b96d02 into FutureTense:main Sep 14, 2026
7 checks passed
@tykeal
tykeal deleted the bump-rollup-plugin-terser branch September 14, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Code chores (dependency updates, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants