Repository navigation
chore(deps-dev): bump @rollup/plugin-terser to 1.0.0 - #794
Conversation
Upgrade @rollup/plugin-terser to clear the high-severity serialize-javascript advisory and the moderate advisory on @rollup/plugin-terser itself, bringing npm audit to 0 vulnerabilities. Both affected packages are dev-only build-time minifier dependencies and are not shipped to users. Version 1.0.0 keeps rollup ^2||^3||^4 peer support, so the repository's rollup ^4.54.0 dependency remains satisfied. The emitted bundle remains byte-identical to the committed artifact, and the existing vitest suite is unaffected. Dependabot cannot propose this bump because lockfiles are intentionally gitignored, as tracked in FutureTense#652. Assisted-by: GitHub Copilot CLI 1.0.83 (Claude Opus 5, model claude-opus-5) Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
===========================================
+ Coverage 84.14% 97.07% +12.92%
===========================================
Files 10 50 +40
Lines 801 6010 +5209
Branches 0 30 +30
===========================================
+ Hits 674 5834 +5160
- Misses 127 176 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; the dependency update addresses vulnerabilities without changing shipped functionality.
Pull request overview
Updates @rollup/plugin-terser from ^0.4.4 to ^1.0.0 to address dependency vulnerabilities while retaining Rollup compatibility.
Changes:
- Bumps the direct development dependency.
- Preserves the existing build tooling configuration.
File summaries
| File | Summary |
|---|---|
package.json |
Updates the Rollup Terser plugin dependency. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Bump the direct devDependency
@rollup/plugin-terserfrom^0.4.4to^1.0.0to clear the known audit findings in the JavaScript build tooling.Before this bump,
npm auditreported 2 vulnerabilities: the moderate directadvisory on
@rollup/plugin-terserand the high-severity transitiveserialize-javascriptadvisory. After the bump,npm auditreports 0vulnerabilities.
Proposed change
This PR updates only the
@rollup/plugin-terserdevDependency range inpackage.json. The affected packages are build-time minifier tooling only andare not shipped to users. Version
1.0.0keepsrollup ^2||^3||^4peer support,so the repository's
rollup ^4.54.0dependency remains satisfied.Local verification used
npm install --legacy-peer-deps,npm audit,npx rollup -c, andnpx vitest run. The rollup build succeeded, the emittedcustom_components/keymaster/www/generated/keymaster.jsbundle remainedbyte-identical to the committed artifact, and all 30 vitest tests passed across
5 files. Dependabot cannot propose this bump automatically because lockfiles are
intentionally gitignored; see #652.
Type of change
Additional information