Repository navigation
fix(settings): decouple model loading and polish settings presentation - #3308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model settings previously held the entire page behind model, proxy, timeout, and catalog reads. Sections now render immediately and become editable when their own data is ready, with isolated failure states and retries.
Type and Areas
Type: Bug fix / UI/UX
Areas: Web UI settings, design-system UI
Motivation / Impact
Slow catalogs or failed network-setting reads no longer block model configuration. Failed model reads keep related write controls locked until a successful retry, avoiding an empty configuration being presented as a successful read.
Verification
pnpm run check:web— passed, including typography, Appearance, theme color audits, theme contracts, package builds, and type checking.pnpm --dir src/web-ui exec tsc --noEmit— passed again after updating to the latest main.pnpm run i18n:audit— passed with zero warnings.pnpm --dir src/web-ui run icons:check— passed.pnpm run motion:audit— inventory reviewed; updated pet transitions include reduced-motion handling.node --test design-system/packages/ui/tests/field-group.test.mjs design-system/packages/ui/tests/combobox.test.mjs design-system/packages/ui/tests/registry.test.mjs— 14 tests passed.git diff --cached --check— passed.Focused Web UI command
Reviewer Notes
No browser automation or mock screenshots were used for visual acceptance. Validation covers source and DOM behavior; rendered visual fidelity remains unverified.
Remote workspace, Remote Control, Peer Device Mode, and Detached Dispatch were not exercised at runtime. Existing configuration keys and transports are retained, and stale-surface checks guard asynchronous results. No persisted schema changes.
Checklist