Skip to content

fix(miniapps): align rating hover states and scope text styles - #3322

Merged
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:bob/fix-miniapp-rating-hover
Oct 9, 2026
Merged

bobleer merged 1 commit into
GCWing:mainfrom
bobleer:bob/fix-miniapp-rating-hover

Conversation

@bobleer

@bobleer bobleer commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix MiniApp rating stars being offset from their hover backgrounds. Rating-summary styles now target an explicit text class instead of every descendant span, preserving the icon button's centering and color in the library, legacy market view, and standalone marketplace.

Apply the same scoping fix to customization/preview headers and detail capability descriptions so text styles no longer override close-button internals or capability titles. Shared OverflowText continues to own clipping.

Type and Areas

Type: Bug fix / UI

Areas: Web UI MiniApps and standalone MiniApp marketplace

Motivation / Impact

Hovering a rating button previously highlighted a box to the left of its star because the statistics margin also matched the button's icon span. Dedicated text classes keep spacing on the statistics and leave the icon centered in its control.

Verification

Passed locally:

  • pnpm run check:web (types, Appearance, typography, theme color and visual contracts)
  • pnpm --dir src/web-ui exec vitest run src/app/scenes/miniapps/components/MiniAppCard.presentation.test.ts src/app/scenes/miniapps/components/miniAppDetailPresentation.test.ts --maxWorkers=50% (17 tests)
  • pnpm run type-check:miniapp-market
  • pnpm run test:miniapp-market (29 tests)
  • pnpm run build:miniapp-market
  • pnpm run motion:audit (reviewed inventory)
  • node scripts/check-git-object-sizes.mjs --base upstream/main --head HEAD
  • git diff --check

Local marketplace browser verification: all five stars have zero horizontal/vertical center offset from their buttons; the third star also stays centered while hovered. Compiled CSS/DOM checks confirm that desktop rating and header text rules no longer match icon/progress spans.

Reviewer Notes

AI-assisted. Testing level: lightly tested (focused tests, build checks, and local browser inspection; no native desktop end-to-end validation). Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised. This change only scopes frontend styles; it does not change persisted data or remote protocols.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable (no copy changes).

@bobleer
bobleer merged commit 396c69c into GCWing:main Oct 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant