Repository navigation
fix(miniapps): align rating hover states and scope text styles - #3322
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix MiniApp rating stars being offset from their hover backgrounds. Rating-summary styles now target an explicit text class instead of every descendant span, preserving the icon button's centering and color in the library, legacy market view, and standalone marketplace.
Apply the same scoping fix to customization/preview headers and detail capability descriptions so text styles no longer override close-button internals or capability titles. Shared OverflowText continues to own clipping.
Type and Areas
Type: Bug fix / UI
Areas: Web UI MiniApps and standalone MiniApp marketplace
Motivation / Impact
Hovering a rating button previously highlighted a box to the left of its star because the statistics margin also matched the button's icon span. Dedicated text classes keep spacing on the statistics and leave the icon centered in its control.
Verification
Passed locally:
pnpm run check:web(types, Appearance, typography, theme color and visual contracts)pnpm --dir src/web-ui exec vitest run src/app/scenes/miniapps/components/MiniAppCard.presentation.test.ts src/app/scenes/miniapps/components/miniAppDetailPresentation.test.ts --maxWorkers=50%(17 tests)pnpm run type-check:miniapp-marketpnpm run test:miniapp-market(29 tests)pnpm run build:miniapp-marketpnpm run motion:audit(reviewed inventory)node scripts/check-git-object-sizes.mjs --base upstream/main --head HEADgit diff --checkLocal marketplace browser verification: all five stars have zero horizontal/vertical center offset from their buttons; the third star also stays centered while hovered. Compiled CSS/DOM checks confirm that desktop rating and header text rules no longer match icon/progress spans.
Reviewer Notes
AI-assisted. Testing level: lightly tested (focused tests, build checks, and local browser inspection; no native desktop end-to-end validation). Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised. This change only scopes frontend styles; it does not change persisted data or remote protocols.
Checklist