Repository navigation
refactor(web-ui): unify remote connection dialog layouts - #3340
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Devices & Connections views used inconsistent headers, card layouts, and action placement. Give the overview, account, phone/browser, and chat-app pages shared layout and typography, with responsive rows and consistent action bars.
Type and Areas
Type: UI/UX, refactor, test.
Areas: Web UI — Remote Connect dialog, account/device panel, locale resources.
Motivation / Impact
Users get consistent navigation and controls across connection methods, clearer setup instructions and status feedback, and usable layouts on narrow screens. Existing account, device-switching, connection, and pairing owners remain in place.
Verification
pnpm run check:web— passed, including TypeScript, Appearance contracts, typography, all 24 theme color surfaces, and theme visual governance.pnpm --dir src/web-ui run test:run src/app/components/RemoteConnectDialog src/infrastructure/design-system/IconUsageIntegration.test.tsx src/app/startup/startupPreload.test.ts— 19 files, 187 tests passed.pnpm run i18n:audit— passed, 0 warnings.pnpm --dir src/web-ui run icons:check— passed.pnpm run motion:audit— inspected; no new motion findings in the changed files.git diff --cached --check— passed before commit.node scripts/check-git-object-sizes.mjs --base upstream/main --head HEAD— passed.Reviewer Notes
AI-assisted review and submission. Testing level: lightly tested end to end; focused frontend checks passed.
Remote control and Peer Device Mode have frontend fixture coverage only. Real remote workspace, remote control, Peer Device Mode, and Detached Dispatch environments were not exercised. No backend command, wire protocol, or persisted data shape changes are included.
Checklist