Repository navigation
fix(release): preserve icon source bytes on Windows - #3403
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Desktop packaging fails during
pnpm installbecause Git converts the Icon Composer and legacy canvas JSON sources to CRLF. Their exact-byte provenance hash then differs from the committed macOS export, andgenerate-brand-assetscorrectly refuses the apparent drift.Pin those two hashed JSON sources to LF. Also disable automatic newline conversion before Windows release checkout, so the existing immutable
v1.0.6tag can be rebuilt with the corrected workflow without retargeting it or relaxing icon/signature verification.Validation:
core.autocrlf=true; reproduced the stale-export failure before the attributes fix and passed afterward. Also verified a checkout without the new attributes when conversion is disabled, covering old-tag rebuilds.node --test scripts/generate-brand-assets.test.mjs scripts/macos-icon-bundle.test.mjs scripts/desktop-tauri-build.test.mjs— 47 passed, 1 skipped (modern icon compilation needs full Xcode on CI).pnpm run generate-brand-assets— passed, no generated asset changes.pnpm run check:github-config— passed, including the Windows pre-checkout ordering contract.pnpm run check:repo-hygieneandgit diff --check— passed.Observed failure: https://github.com/GCWing/OpenBitFun/actions/runs/38697459708/job/116297423408
AI-assisted; focused checkout and packaging contract tests. No remote workspace, remote control, Peer Device Mode or Detached Dispatch scenarios exercised; runtime behavior, payloads and mobile release configuration are unchanged.