Skip to content

Add CrIS-FSR_N21 Observations to the EnKF #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gmao-wgu wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add CrIS-FSR_N21 Observations to the EnKF #390

gmao-wgu wants to merge 1 commit into from

Conversation

@gmao-wgu
Copy link

@gmao-wgu gmao-wgu commented Jul 19, 2025 •
edited
Loading

Adding CrIS-FSR observations from NOAA-21 to the ENKF

Dependency: GEOS-ESM/GEOSana_GridComp#209

@gmao-wgu gmao-wgu requested a review from a team as a code owner July 19, 2025 01:45
@gmao-wgu gmao-wgu added the Non 0-diff The changes in this pull request are non-zero-diff label Jul 19, 2025
@gmao-wgu gmao-wgu changed the title Add cris-fsr_n21 observations into to the EnKF Add CrIS-FSR_N21 observations to the EnKF Jul 19, 2025
@gmao-wgu gmao-wgu changed the title Add CrIS-FSR_N21 observations to the EnKF Add CrIS-FSR_N21 Observations to the EnKF Jul 19, 2025
gmao-yzhu
gmao-yzhu approved these changes Jul 21, 2025
View reviewed changes
Copy link

@gmao-yzhu gmao-yzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me.

mhan-mars
mhan-mars approved these changes Jul 22, 2025
View reviewed changes
Copy link

@mhan-mars mhan-mars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me.

ahrem1234
ahrem1234 reviewed Jul 25, 2025
View reviewed changes
Copy link

@ahrem1234 ahrem1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add src/Applications/NCEP_Etc/NCEP_bias/sac.nl.tmpl file changed here?

@gmao-wgu
Copy link
Author

gmao-wgu commented Jul 25, 2025

Do we need to add src/Applications/NCEP_Etc/NCEP_bias/sac.nl.tmpl file changed here?
@ahrem1234 That file is from the old bias correction scheme, in which the angle bias was handled outside of GSI. It is no longer in use.

@ahrem1234
Copy link

ahrem1234 commented Jul 25, 2025

Do we need to add src/Applications/NCEP_Etc/NCEP_bias/sac.nl.tmpl file changed here?
@ahrem1234 That file is from the old bias correction scheme, in which the angle bias was handled outside of GSI. It is no longer in use.

Thank you for your comments. Then, this PR looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmao-yzhu gmao-yzhu gmao-yzhu approved these changes

@mhan-mars mhan-mars mhan-mars approved these changes

@ahrem1234 ahrem1234 ahrem1234 approved these changes

@rtodling rtodling Awaiting requested review from rtodling

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Non 0-diff The changes in this pull request are non-zero-diff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gmao-wgu @ahrem1234 @gmao-yzhu @mhan-mars