Add gap-free topology documentation and plot_topology() convenience helper#401
Merged
Merged
Conversation
- Document the backbone-first pattern for gap-free topology rendering in get_ridges/plot_ridges, get_trenches/plot_trenches, get_transforms/plot_transforms - Add plot_topology() convenience method to PlotTopologies that handles the backbone-first ordering internally (backbone → ridges → transforms → trenches) - Add tests for plot_topology in test_3_plottopologies.py
Copilot
AI
changed the title
[WIP] Fix gaps in topological-boundary rendering
Add gap-free topology documentation and Jun 9, 2026
plot_topology() convenience helper
…ions independently
Removed two test functions for plot_topology from test_3_plottopologies.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plotting individual boundary types (
plot_ridges,plot_transforms,plot_trenches) in isolation leaves visible gaps along "other connection" segments. The fix is to renderplot_all_topological_sections()as a continuous backbone first, then layer the styled boundaries on top — a pattern used across the tutorial suite but undiscovered by most users.Changes
Documentation
.. note::block toget_ridges,plot_ridges,get_trenches,plot_trenches,get_transforms, andplot_transformsexplaining:plot_topology()helperNew
PlotTopologies.plot_topology()helperConvenience method that enforces correct draw order internally: backbone → ridges → transforms → trenches.
Parameter semantics:
None→ draw with default style;dict→ draw with custom kwargs;False→ skip layer. Transforms are skipped (False) by default since they visually overlap with ridges.Tests
Added
test_plot_topology_adds_artistsandtest_plot_topology_skip_layertotest_3_plottopologies.py.