Skip to content

fix: add BankKeeper dependency injection #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Galiusbro merged 1 commit into from
Aug 31, 2025
Merged

fix: add BankKeeper dependency injection #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions x/tokenfactory/keeper/msg_server_set_denom_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ func (k msgServer) SetDenomMetadata(goCtx context.Context, msg *types.MsgSetDeno
Description: msg.Description,
}

if err := k.bankKeeper.SetDenomMetaData(ctx, md); err != nil {
return nil, err
}
k.bankKeeper.SetDenomMetaData(ctx, md)

return &types.MsgSetDenomMetadataResponse{}, nil
}
3 changes: 2 additions & 1 deletion x/tokenfactory/module/depinject.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"cosmossdk.io/depinject/appconfig"
"github.com/cosmos/cosmos-sdk/codec"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
bankkeeper "github.com/cosmos/cosmos-sdk/x/bank/keeper"

"github.com/you/nuahchain/x/tokenfactory/keeper"
"github.com/you/nuahchain/x/tokenfactory/types"
Expand All @@ -34,7 +35,7 @@ type ModuleInputs struct {
AddressCodec address.Codec

AuthKeeper types.AuthKeeper
BankKeeper types.BankKeeper
BankKeeper bankkeeper.BaseKeeper
}

type ModuleOutputs struct {
Expand Down
2 changes: 1 addition & 1 deletion x/tokenfactory/types/expected_keepers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type BankKeeper interface {
BurnCoins(context.Context, string, sdk.Coins) error
SendCoinsFromModuleToAccount(context.Context, string, sdk.AccAddress, sdk.Coins) error
SendCoinsFromAccountToModule(context.Context, sdk.AccAddress, string, sdk.Coins) error
SetDenomMetaData(context.Context, banktypes.Metadata) error
SetDenomMetaData(context.Context, banktypes.Metadata)
}

// ParamSubspace defines the expected Subspace interface for parameters.
Expand Down