fix(consensus): improve error handling and remove unreachable panics#645
Merged
Lchangliang merged 2 commits intomainfrom Apr 10, 2026
Merged
fix(consensus): improve error handling and remove unreachable panics#645Lchangliang merged 2 commits intomainfrom
Lchangliang merged 2 commits intomainfrom
Conversation
This was referenced Apr 8, 2026
Lchangliang
force-pushed
the
dev-0408-audit
branch
from
a1b8513 to
a8885ba
Compare
Replace unwrap/unreachable panics with proper error handling across consensus modules to improve node resilience. Key changes: - epoch_manager: guard round_manager_tx access during epoch transitions - payload_manager: replace unreachable!() with error logging and graceful return - buffer_manager: add commit vote cache size limit (1000) to prevent OOM - ledger_metadata_db: propagate Result instead of expect/unwrap on DB reads - block_buffer_manager: handle missing block_number gracefully in init - bootstrap: simplify block_number_to_block_id population with entry API - sync_manager: handle ledger info range query errors gracefully Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Lchangliang
force-pushed
the
dev-0408-audit
branch
from
a8885ba to
ec43d2b
Compare
ByteYue
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unwrap/unreachable panics with proper error handling across consensus modules to improve node resilience. Key changes: