fix: time-based detour baseline + station toggle cleanup#24
Merged
Conversation
Detour math: the proportional baseline (routeDuration * segFraction) used geographic distance as a proxy for time, producing wildly wrong detour estimates where speed varies along the route (e.g. Erla showed +51min instead of +12min). Now builds per-coordinate cumulative durations from Valhalla maneuver timing and sends them to the detour API. Baseline = routeDurations[rejoinIdx] - routeDurations[exitIdx], which is the exact driving time for that segment. Station toggle: deselecting a station (map or sidebar) now properly removes the isStationLeg waypoint. Previously only cleared the route overlay but left the waypoint in state, preventing clean deselection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routeDuration * geographicFraction) was fundamentally broken because speed varies along the route — highway segments cover lots of distance quickly while city segments are slow per km. Now extracts per-maneuver timing from Valhalla's route response, builds cumulative durations at each coordinate, and sends them to the detour API. The baseline for each station's window isrouteDurations[rejoinIdx] - routeDurations[exitIdx]— the exact driving time on the original route, not an approximation.isStationLegwaypoint from state. Previously it only cleared the route overlay but left the stale waypoint, preventing reliable toggle-off behavior.Test plan