Skip to content

fix: skip hosts entries for domains managed by other tools#31

Merged
GeiserX merged 1 commit intomainfrom
fix/hosts-collision-detection
Apr 17, 2026
Merged

fix: skip hosts entries for domains managed by other tools#31
GeiserX merged 1 commit intomainfrom
fix/hosts-collision-detection

Conversation

@GeiserX
Copy link
Copy Markdown
Owner

@GeiserX GeiserX commented Apr 17, 2026

Summary

  • When writing to /etc/hosts, VPN Bypass now checks if a domain already exists outside its VPN-BYPASS-MANAGED block
  • If another tool (AgentTap, Pi-hole, etc.) already manages that domain, VPN Bypass skips it to avoid conflicts
  • Prevents VPN Bypass from overriding other tools' DNS interception entries

Test plan

  • Configure VPN Bypass with domains that overlap with another hosts-managing tool
  • Verify overlapping domains are skipped in the VPN-BYPASS-MANAGED block
  • Verify non-overlapping domains are still written normally
  • Verify cleanup on quit still works correctly

When updating /etc/hosts, check if a domain already exists outside the
VPN-BYPASS-MANAGED block (e.g. managed by AgentTap, Pi-hole, etc.)
and skip it to avoid conflicts.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Warning

Rate limit exceeded

@GeiserX has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 46 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 46 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fc047eea-81a3-4945-875b-7fe9fa0c36ea

📥 Commits

Reviewing files that changed from the base of the PR and between 0733c66 and 7833dbe.

📒 Files selected for processing (1)
  • Helper/HelperTool.swift
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hosts-collision-detection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GeiserX GeiserX merged commit 2b85979 into main Apr 17, 2026
7 checks passed
@GeiserX GeiserX deleted the fix/hosts-collision-detection branch April 17, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant