fix(asi04-PR-48): restructure MCPRegistrySwitchDetector for MCPServerConfig architecture#485
Open
syedDS wants to merge 6 commits intoGenAI-Security-Project:mainfrom
Open
fix(asi04-PR-48): restructure MCPRegistrySwitchDetector for MCPServerConfig architecture#485syedDS wants to merge 6 commits intoGenAI-Security-Project:mainfrom
syedDS wants to merge 6 commits intoGenAI-Security-Project:mainfrom
Conversation
Signed-off-by: aamir <32578528+syedDS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors PR #48 (ASI04 insecure MCP registry challenge) to align with the finbot admin panel's new MCP server config architecture. Fixes three integration gaps identified in comment:
Registration: MCPRegistrySwitchDetector was never registered in the auto-discovery pipeline
Attack surface model: Original challenge assumed a remote "registry URL" field; new architecture uses in-process servers with config_json mutations
Detection logic: check_aggregate was scanning vendor text fields, not the actual MCPServerConfig records