Skip to content

Fix CRAN results #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maksymiuks merged 1 commit into from
Jun 10, 2025
Merged

Fix CRAN results #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: checked
Title: Systematically Run R CMD Checks
Version: 0.2.8.9000
Version: 0.2.9
Authors@R:
c(
person(
Expand Down
8 changes: 7 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
# checked (devel)
# checked (0.2.9)

* Add `igraph_subgraph_from_edges` wrapper to used work around deprecation
messages and alternate between `igraph::subgraph.edges` and
`igraph::subgraph_from_edges` depending on the `igraph` version.

* Address CRAN results issues

* In `install_packages_process` use `withCallingHandlers` instead
of the `tryCatch` to prevent accidental interruptions if `install.packages()`
triggers a benign warning.

# checked 0.2.8

Expand Down
2 changes: 1 addition & 1 deletion R/install.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ install_packages_process <- R6::R6Class(
private$callr_r_bg(
function(..., escalate_warning, available_packages_filters) {
options(available_packages_filters = available_packages_filters)
tryCatch(
withCallingHandlers(
utils::install.packages(...),
warning = function(w) {
if (escalate_warning(w)) {
Expand Down
2 changes: 1 addition & 1 deletion R/task_graph.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ is_package_satisfied <- function(v, lib.loc) { # nolint object_name_linter
}

igraph_subgraph_from_edges <- function(...) {
if (packageVersion("igraph") < "2.1.0") {
if (utils::packageVersion("igraph") < "2.1.0") {
igraph::subgraph.edges(...)
} else {
igraph::subgraph_from_edges(...)
Expand Down
3 changes: 2 additions & 1 deletion man/custom_install_task_spec.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion man/install_task_spec.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions tests/testthat/test-checks_df.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ path <- c(
file.path(examples_path, "exampleOkay"),
file.path(examples_path, "exampleBad")
)
expected_revdeps <- tools::package_dependencies(
"DALEXtra",
db = utils::available.packages(repos = "https://cran.r-project.org/"),
reverse = TRUE,
which = "all"
)[[1]]

test_that("rev_dep_check_tasks_df works with deafult params", {
expect_silent(
Expand All @@ -15,7 +21,7 @@ test_that("rev_dep_check_tasks_df works with deafult params", {
)
)
expect_s3_class(df, "data.frame")
expect_true(NROW(df) >= 8)
expect_true(NROW(df) >= 2*length(expected_revdeps))
expect_named(df, c("alias", "version", "package", "custom"))

expect_s3_class(df$package, "list_of_task_spec")
Expand Down Expand Up @@ -118,7 +124,7 @@ test_that("rev_dep_check_tasks_df development_only = TRUE", {
)
)
expect_s3_class(df, "data.frame")
expect_true(NROW(df) >= 4)
expect_true(NROW(df) >= length(expected_revdeps))
expect_named(df, c("alias", "version", "package", "custom"))

expect_s3_class(df$package, "list_of_task_spec")
Expand Down
Loading