Repository navigation
Figure.histogram: Support Pythonic arguments for the 'histtype' parameter - #4912
Merged
Merged
Conversation
26 of 40 tasks
seisman
marked this pull request as ready for review
October 14, 2026 11:41
seisman
added
final review call
| reason="Cannot use 'cmap' when 'fill' is a constant color or pattern.", | ||
| ) | ||
|
|
||
| # The legacy syntax gives the histogram type as a string, optionally with the "+w" |
Member
There was a problem hiding this comment.
Maybe use "old" instead of "legacy"?
yvonnefroehlich
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
histtypecan be 0-6, which is not readable. This PR uses more readable names.Preview: https://pygmt-dev--4912.org.readthedocs.build/en/4912/api/generated/pygmt.Figure.histogram.html