-
Notifications
You must be signed in to change notification settings - Fork 309
Fix messages from muted users increasing channel unread count #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix messages from muted users increasing channel unread count #6061
Conversation
SDK Size Comparison 📏
|
WalkthroughAdded a guard in channel read-update logic to ignore messages authored by globally muted users and a test plus changelog entry to prevent such messages from increasing channel unread counts. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…increasing_unread_count
|



🎯 Goal
Incoming messages from muted users don't increase the unread count server-side, so we shouldn't increase it client-side as well.
🛠 Implementation details
Add guard in
ChannelStateLogic.updateCurrentUserReadpreventing the unread count from increasing for messages from muted users.🎨 UI Changes
muted_before.mov
muted_after.mov
🧪 Testing
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.