add: creating component RoundColor - #377
Draft
LucaMaggioli wants to merge 4 commits into
Draft
Conversation
Melvynx
suggested changes
May 20, 2021
Melvynx
left a comment
Melvynx
left a comment
Member
There was a problem hiding this comment.
le but de faire ce composant c'est ensuite pour l'utiliser dans RandomColor et PreciseColorPicker
| disabled, | ||
| onClick, | ||
| }: RoundColorProps) { | ||
| const disabledColor = theme.palette.action.disabled; |
Member
There was a problem hiding this comment.
Suggested change
| const disabledColor = theme.palette.action.disabled; | |
| const theme = useTheme(); | |
| const disabledColor = theme.palette.action.disabled; |
Contributor
Author
There was a problem hiding this comment.
le but de faire ce composant c'est ensuite pour l'utiliser dans
RandomColoretPreciseColorPicker
Yes mais je ne savais pas si le componant allais bien, du coups c'est pour ça que je l'ai mis en Draft, du coups je l'applique à RandomColor et PreciseColorPicker
… precisecolorPicker have to be 'unselected'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creating a component to make a round color
proprs:
RESOLVE #353
Checklist
sprintbranchReview in progress