Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion evalbench/scorers/pythonscorer.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ class PythonScorer(comparator.Comparator):

def __init__(self, config: dict, name: str = "python_scorer"):
super().__init__(config)
self.config = config or {}
self.name = name
self.script_path = config.get("script_path")
self.script_path = self.config.get("script_path")
if not self.script_path:
raise ValueError("script_path is required for PythonScorer")

Expand Down Expand Up @@ -59,7 +60,15 @@ def compare(
"generated_error": generated_error,
"database": database,
"sqlite_db_dir": self.sqlite_db_dir,
"config": self.config,
"kwargs": kwargs,
}
for k, v in self.config.items():
if k not in input_data and k != "script_path":
input_data[k] = v
for k, v in kwargs.items():
if k not in input_data:
input_data[k] = v

try:
json_input = json.dumps(input_data)
Expand Down
27 changes: 27 additions & 0 deletions evalbench/test/pythonscorer_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,33 @@ def test_python_scorer_uv_not_found(self, mock_run):
self.assertEqual(score, 0.0)
self.assertIn("FAIL: 'uv' command not found", reason)

@patch('scorers.pythonscorer.subprocess.run')
def test_python_scorer_kwargs_and_config_passing(self, mock_run):
mock_result = MagicMock()
mock_result.returncode = 0
mock_result.stdout = '{"score": 100.0, "reason": "OK"}'
mock_result.stderr = ""
mock_run.return_value = mock_result

config = {"script_path": "dummy_script.py", "custom_param": "value123"}
scorer = PythonScorer(config)

scorer.compare(
nl_prompt="p", golden_query="g", query_type="DQL",
golden_execution_result="", golden_eval_result="", golden_error="",
generated_query="gen", generated_execution_result="",
generated_eval_result="", generated_error="",
extra_runtime_arg="arg456"
)

args, kwargs = mock_run.call_args
sent_input = json.loads(kwargs["input"])
self.assertIn("kwargs", sent_input)
self.assertEqual(sent_input["kwargs"].get("extra_runtime_arg"), "arg456")
self.assertEqual(sent_input.get("extra_runtime_arg"), "arg456")
self.assertEqual(sent_input.get("custom_param"), "value123")
self.assertIn("config", sent_input)


if __name__ == '__main__':
unittest.main()
Loading