Allow per-dialect schema files - #569
Merged
prernakakkar-google merged 3 commits intoAug 14, 2026
Merged
Conversation
aseering
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
August 12, 2026 19:10
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aseering
force-pushed
the
feature/dialect-aware-setup-clean-v2
branch
from
August 12, 2026 20:39
a818dc1 to
d973d76
Compare
Collaborator
Author
|
/gcbrun |
- Update _get_setup_values to try dialect subdirectory first - Update callers in db_manager.py to pass dialect - Add test_db_manager.py unit tests TAG=agy-duckie
aseering
force-pushed
the
feature/dialect-aware-setup-clean-v2
branch
from
August 12, 2026 21:00
d973d76 to
c8b4e9d
Compare
prernakakkar-google
approved these changes
Aug 13, 2026
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
yep, still not a collaborator. Would someone who is, mind kicking off the tests here? |
Collaborator
|
/gcbrun |
Collaborator
Added you as collaborator. Thanks Adam for contributions. |
prernakakkar-google
merged commit Aug 14, 2026
ce34685
into
GoogleCloudPlatform:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spanner has two distinct dialects (PostgreSQL and GoogleSQL): The engine is functionally the same and the dataset is the same, but the schema .sql files need to be different per-database. This change adds automatic (but optional) support for having per-dialect schema files in a dataset.