Skip to content

test(e2e): making client-protocol explicit to make agnostic of default value#4801

Merged
PranjalC100 merged 1 commit into
masterfrom
explicit_client_protocol
Jul 1, 2026
Merged

test(e2e): making client-protocol explicit to make agnostic of default value#4801
PranjalC100 merged 1 commit into
masterfrom
explicit_client_protocol

Conversation

@raj-prince

Copy link
Copy Markdown
Collaborator

Description

Link to the issue in case of a bug fix.

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@raj-prince raj-prince added the execute-integration-tests Run only integration tests label Jun 24, 2026
@raj-prince raj-prince changed the title test(e2e): keeping client-protocol explicit to make agnostic of default value test(e2e): making client-protocol explicit to make agnostic of default value Jun 24, 2026
@raj-prince raj-prince marked this pull request as ready for review June 26, 2026 09:56
@raj-prince raj-prince requested review from a team and meet2mky as code owners June 26, 2026 09:56
@github-actions github-actions Bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Jun 26, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the integration test configuration file to explicitly define the client protocol as 'http1' across various test scenarios. By making this configuration explicit, the tests become more robust and less dependent on default protocol settings, which helps prevent potential regressions or inconsistencies in test execution.

Highlights

  • Explicit client protocol configuration: Updated integration test configurations to explicitly set '--client-protocol=http1' where it was previously omitted, ensuring consistent test behavior independent of default values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (4822558) to head (3d20762).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #4801   +/-   ##
==============================
==============================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration test configurations in tools/integration_tests/test_config.yaml to explicitly include the --client-protocol=http1 flag across multiple test suites. The review feedback identifies several instances where flags are incorrectly separated by spaces instead of commas, which could cause parsing errors during test execution. Correcting these formatting issues to use commas consistently is recommended.

Comment thread tools/integration_tests/test_config.yaml
Comment thread tools/integration_tests/test_config.yaml Outdated
Comment thread tools/integration_tests/test_config.yaml Outdated
Comment thread tools/integration_tests/test_config.yaml Outdated
@github-actions

Copy link
Copy Markdown

Hi @meet2mky, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

Comment thread tools/integration_tests/test_config.yaml
@meet2mky

Copy link
Copy Markdown
Collaborator

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration test configurations in tools/integration_tests/test_config.yaml to explicitly specify --client-protocol=http1 for non-gRPC test runs. The review feedback correctly identifies a couple of test cases under symlink_handling where this explicit protocol flag was missed, and suggests adding it for consistency.

Comment thread tools/integration_tests/test_config.yaml Outdated
Comment thread tools/integration_tests/test_config.yaml Outdated
@github-actions

Copy link
Copy Markdown

Hi @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@raj-prince raj-prince force-pushed the explicit_client_protocol branch from 4f16988 to 829b51a Compare July 1, 2026 09:55

@meet2mky meet2mky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PranjalC100 PranjalC100 merged commit ceee4c5 into master Jul 1, 2026
17 checks passed
@PranjalC100 PranjalC100 deleted the explicit_client_protocol branch July 9, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants