Skip to content

CI - Adding grcov reporting into pipeline - #9

Open
JesseStorms wants to merge 12 commits into
v1.0.0from
ci/coverage
Open

CI - Adding grcov reporting into pipeline#9
JesseStorms wants to merge 12 commits into
v1.0.0from
ci/coverage

Conversation

@JesseStorms

@JesseStorms JesseStorms commented Jun 9, 2025

Copy link
Copy Markdown

the build workflow (should) now include the coverage reports as artifacts in the repository using grcov. Coverage will be checked after compilation, since it doesn't make sense testing what doesn't even compile...

notes

  • This PR is a draft to prevent it from already running. 'Opening' this PR should make this workflow run
    • This is to prevent wasting CI time. It would be nice to actually test this on the runners
  • This PR brings eff2e02 into v1.0.0

AnnaThorne and others added 3 commits May 29, 2025 23:06
@AnnaThorne
ci: 🔨 add pipeline
eff2e02 
* ci: 🔨 create pipeline to build and test the proj

* fix: 🔨 pipe fix

no scope

* ci: 👽 cleanup
@JesseStorms
merging main into ci/coverage
438bbd6 
for some reason we already have a pipeline, but i'm just adding coverage to it
@JesseStorms
ci - implemented coverage with grcov
d8d2ddb
@JesseStorms JesseStorms self-assigned this Jun 9, 2025
@JesseStorms JesseStorms added the enhancement New feature or request label Jun 9, 2025
@JesseStorms JesseStorms moved this to In Progress in AtomizeR Roadmap Jun 9, 2025
@JesseStorms

JesseStorms commented Jun 9, 2025

Copy link
Copy Markdown
Author

alright someone at github decided that a draft is considered the same as being open for some reason

@JesseStorms
JesseStorms force-pushed the ci/coverage branch 5 times, most recently from faacb55 to cf24f8f Compare June 9, 2025 23:09
@JesseStorms

JesseStorms commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

https://github.com/Hellspawn-Corp/AtomizeR/actions/runs/15546592206
currently it just tosses it into a zip, but it works.

Merge when it looks good, or ask for changes and revert to draft when it's not good

@JesseStorms
JesseStorms marked this pull request as ready for review June 9, 2025 23:19
@FaithfulFox

FaithfulFox commented Jun 10, 2025

Copy link
Copy Markdown

need to get the time down on this. 5 mins is wild bro.. 🫨 💩

@JesseStorms

JesseStorms commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

need to get the time down on this. 5 mins is wild bro.. 🫨 💩

will look into caching, however note that (i think) GH only permits 500mb for cached storage?

Alternatively, we could use a self-hosted runner

AnnaThorne
AnnaThorne requested changes Jun 10, 2025
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml
@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown

LCOV of commit e596c0b during atomizer main pipeline #16

Summary coverage rate:
  lines......: 24.3% (116 of 478 lines)
  functions..: 27.0% (17 of 63 functions)
  branches...: no data found

Files changed coverage rate: n/a

@JesseStorms
JesseStorms requested a review from AnnaThorne June 12, 2025 12:32
AnnaThorne
AnnaThorne requested changes Jul 9, 2025
View reviewed changes

@AnnaThorne AnnaThorne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ding ding ding ding needs caching 🔔 🔔 🔔

@github-actions

github-actions Bot commented Jul 10, 2025

Copy link
Copy Markdown

LCOV of commit d2b75a0 during atomizer main pipeline #17

Summary coverage rate:
  lines......: 25.3% (108 of 427 lines)
  functions..: 28.3% (17 of 60 functions)
  branches...: no data found

Files changed coverage rate: n/a

@github-actions

github-actions Bot commented Jul 10, 2025

Copy link
Copy Markdown

running 5 tests
test logic::converter::json_input_to_json_entries::test::test_convert_user_input_to_entries ... ok
test utils::tests::test::it_panics_if_file_cant_be_read ... ok
test utils::tests::test::it_panics_if_json_not_valid ... ok
test utils::tests::test::it_panics_on_non_unique_id ... ok
test utils::tests::test::it_parses_json_input ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

@github-actions

github-actions Bot commented Jul 10, 2025

Copy link
Copy Markdown

LCOV of commit b042430 during atomizer main pipeline #18

Summary coverage rate:
  lines......: 25.3% (108 of 427 lines)
  functions..: 28.3% (17 of 60 functions)
  branches...: no data found

Files changed coverage rate: n/a

@JesseStorms
JesseStorms requested a review from AnnaThorne July 10, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FaithfulFox FaithfulFox Awaiting requested review from FaithfulFox
@AnnaThorne AnnaThorne Awaiting requested review from AnnaThorne

Assignees

@JesseStorms JesseStorms

Labels

enhancement New feature or request

Projects

AtomizeR Roadmap
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JesseStorms @FaithfulFox @AnnaThorne