Skip to content

Make GRS rotation (R) angle overlay label show values between -360° and 360° #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keavon merged 7 commits into from
Apr 9, 2025
Merged

Make GRS rotation (R) angle overlay label show values between -360° and 360° #2473

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9129be5
Fixes issues
4adex Mar 19, 2025
1681e02
Merge branch 'master' into minor_fixes
Keavon Mar 20, 2025
ea9b4e2
Revert changes
4adex Mar 20, 2025
8befd15
Viewing angle using R
4adex Mar 20, 2025
be787c7
Merge branch 'master' into minor_fixes
Keavon Apr 6, 2025
c14156d
Merge branch 'master' into minor_fixes
Keavon Apr 9, 2025
fb7ae41
Revert other fix so it can be its own PR
Keavon Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion editor/src/messages/tool/transform_layer/transform_layer_message_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,15 @@ impl MessageHandler<TransformLayerMessage, TransformData<'_>> for TransformLayer
let radius = start_mouse.distance(pivot);
let arc_radius = ANGLE_MEASURE_RADIUS_FACTOR * width;
let radius = radius.clamp(ARC_MEASURE_RADIUS_FACTOR_RANGE.0 * width, ARC_MEASURE_RADIUS_FACTOR_RANGE.1 * width);
let text = format!("{}°", format_rounded(angle.to_degrees(), 2));
let angle_in_degrees = angle.to_degrees();
let display_angle = if angle_in_degrees.is_sign_positive() {
angle_in_degrees - (angle_in_degrees / 360.).floor() * 360.
} else if angle_in_degrees.is_sign_negative() {
angle_in_degrees - ((angle_in_degrees / 360.).floor() + 1.) * 360.
} else {
angle_in_degrees
};
let text = format!("{}°", format_rounded(display_angle, 2));
let text_texture_width = overlay_context.get_width(&text) / 2.;
let text_texture_height = 12.;
let text_angle_on_unit_circle = DVec2::from_angle((angle % TAU) / 2. + offset_angle);
Expand Down
Loading