[TrueDoctor]

Make all document node ids universally unique, aligning their generation with the storage nodes such that we can use storage node ids as runtime ids and skip the runtime -> storage conversion

[github-actions]

This PR's title needs revising to follow the project's conventions:

• Its opening verb should say what the change does to the software, rather than something the software itself does or becomes able to do (like "Render").
• It describes how the change works, rather than what users get from it.
• It's too vague to tell what the change does.

Suggested titles:

Unify the runtime and storage node ID spaces so storage keys nodes by their runtime IDs

Replace hashed storage node IDs with the runtime node IDs, and make built-in node contents read-only until made editable

Use runtime node IDs as the storage node IDs and drop the ORIGINAL_NODE_ID attribute

_{Editing the title reviews it again.}

[cubic-dev-ai]

All reported issues were addressed across 41 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

1 issue found across 12 files (changes from recent commits).

Confidence score: 5/5

• In node-graph/nodes/raster/src/filter.rs, the joined && clauses don’t match this repo’s rustfmt layout. Put each clause on its own line.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/raster/src/filter.rs">

<violation number="1" location="node-graph/nodes/raster/src/filter.rs:232">
P3: This change joins two `&&` clauses onto one line, which is not how rustfmt lays out multi-line `if` conditions in this repo. Put each clause on its own line so the file matches `cargo fmt` output.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P3: This change joins two && clauses onto one line, which is not how rustfmt lays out multi-line if conditions in this repo. Put each clause on its own line so the file matches cargo fmt output.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At node-graph/nodes/raster/src/filter.rs, line 232:

<comment>This change joins two `&&` clauses onto one line, which is not how rustfmt lays out multi-line `if` conditions in this repo. Put each clause on its own line so the file matches `cargo fmt` output.</comment>

<file context>
@@ -229,8 +229,7 @@ where
 					if p >= 0
-						&& p < max as i32
-						&& let Some(px) = old_buffer.get_pixel([p as u32, x][pass], [y, p as u32][pass])
+						&& p < max as i32 && let Some(px) = old_buffer.get_pixel([p as u32, x][pass], [y, p as u32][pass])
 					{
 						r_sum += px.r() as f64 * weight;
</file context>

Suggested change

	&& p < max as i32 && let Some(px) = old_buffer.get_pixel([p as u32, x][pass], [y, p as u32][pass])
	&& p < max as i32
	&& let Some(px) = old_buffer.get_pixel([p as u32, x][pass], [y, p as u32][pass])