Skip to content

Remove unused loading state and Settings import from StaffDashboard#37

Merged
AkibDa merged 3 commits intojeet-mainfrom
copilot/sub-pr-36
Jan 17, 2026
Merged

Remove unused loading state and Settings import from StaffDashboard#37
AkibDa merged 3 commits intojeet-mainfrom
copilot/sub-pr-36

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 17, 2026

Addresses code review feedback from #36 regarding unused variables in Pages/StaffDashboard.tsx.

Changes

  • Removed unused loading state variable and its setter from the orders fetch useEffect
  • Removed unused Settings import from lucide-react
  • Fixed import statement spacing for consistency
// Before
const [loading, setLoading] = useState(true)
// ...
} catch (err) {
  console.error("Failed to fetch staff orders", err)
} finally {
  setLoading(false)  // Never read
}

// After
// ...
} catch (err) {
  console.error("Failed to fetch staff orders", err)
}

The component never used the loading state for conditional rendering or UX feedback, making it dead code.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 17, 2026 17:41
Co-authored-by: AkibDa <179389698+AkibDa@users.noreply.github.com>
Co-authored-by: AkibDa <179389698+AkibDa@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on Jeet main pull request Remove unused loading state and Settings import from StaffDashboard Jan 17, 2026
Copilot AI requested a review from AkibDa January 17, 2026 17:43
@AkibDa AkibDa marked this pull request as ready for review January 17, 2026 17:44
@AkibDa AkibDa merged commit e1ea0f9 into jeet-main Jan 17, 2026
@AkibDa AkibDa deleted the copilot/sub-pr-36 branch January 26, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants