Skip to content

Bump#47

Merged
kostyanf14 merged 3 commits into
mainfrom
bump
Apr 28, 2026
Merged

Bump#47
kostyanf14 merged 3 commits into
mainfrom
bump

Conversation

@kostyanf14
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Copilot AI review requested due to automatic review settings April 27, 2026 18:01
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the required Ruby version to 3.3.7, introduces a version check in autohck.sh, and updates dependency references for several components. Additionally, it corrects firmware path logic for Red Hat-based distributions in qemu.sh. Feedback was provided to improve the robustness and consistency of the Ruby installation logic when an outdated version is detected.

Comment thread autohck.sh
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates bootstrap/install dependencies and environment requirements for running AutoHCK and QEMU-based HLK workflows.

Changes:

  • Adjusted OVMF firmware fallback paths for CentOS/RHEL/Fedora in qemu.sh.
  • Bumped pinned refs for extra-software, hckfilters, and AutoHCK in dependencies.sh (and removed HLK_SETUP_SCRIPTS from the dependency list).
  • Centralized Ruby version in autohck.sh and added logic to enforce/install a minimum Ruby version.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
qemu.sh Tweaks OVMF path fallbacks for secure vs insecure firmware images.
dependencies.sh Updates pinned dependency refs and removes HLK_SETUP_SCRIPTS from the dependency list.
autohck.sh Introduces RUBY_VERSION and adds a Ruby version gate with optional rvm-based installation.
Comments suppressed due to low confidence (1)

dependencies.sh:10

  • HLK_SETUP_SCRIPTS was removed from DEPENDENCIES and its *_GIT/*_REF settings were deleted, but the install flow still expects HLK_SETUP_SCRIPTS_DIR to be available when generating override.install.json (see config.sh, which reads ${HLK_SETUP_SCRIPTS_DIR}). With this change, HLK_SETUP_SCRIPTS_DIR will be unset/empty and the generated AutoHCK override will contain an invalid hck_setup_scripts_path.

Suggested fix: either re-add HLK_SETUP_SCRIPTS to DEPENDENCIES (and restore the variables) so install.sh populates HLK_SETUP_SCRIPTS_DIR, or update the config generation to stop referencing HLK_SETUP_SCRIPTS_DIR / remove that override field if AutoHCK no longer needs it.

DEPENDENCIES=(
    VIRTIOFSD
    QEMU
    EXTRA_SOFTWARE
    HLK_PLAYLISTS
    HCK_FILTERS
    AUTOHCK
)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread autohck.sh
- EXTRA_SOFTWARE: 6fc4577 -> f92e660
- HCK_FILTERS: fdfeaa2 -> 364fa8e
- AUTOHCK: v0.17.7 -> v0.18.0
- HLK_SETUP_SCRIPTS: drop

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
@kostyanf14 kostyanf14 merged commit 5576ae0 into main Apr 28, 2026
6 checks passed
@kostyanf14 kostyanf14 deleted the bump branch April 28, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants