Bump#47
Conversation
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request updates the required Ruby version to 3.3.7, introduces a version check in autohck.sh, and updates dependency references for several components. Additionally, it corrects firmware path logic for Red Hat-based distributions in qemu.sh. Feedback was provided to improve the robustness and consistency of the Ruby installation logic when an outdated version is detected.
There was a problem hiding this comment.
Pull request overview
Updates bootstrap/install dependencies and environment requirements for running AutoHCK and QEMU-based HLK workflows.
Changes:
- Adjusted OVMF firmware fallback paths for CentOS/RHEL/Fedora in
qemu.sh. - Bumped pinned refs for
extra-software,hckfilters, andAutoHCKindependencies.sh(and removedHLK_SETUP_SCRIPTSfrom the dependency list). - Centralized Ruby version in
autohck.shand added logic to enforce/install a minimum Ruby version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| qemu.sh | Tweaks OVMF path fallbacks for secure vs insecure firmware images. |
| dependencies.sh | Updates pinned dependency refs and removes HLK_SETUP_SCRIPTS from the dependency list. |
| autohck.sh | Introduces RUBY_VERSION and adds a Ruby version gate with optional rvm-based installation. |
Comments suppressed due to low confidence (1)
dependencies.sh:10
HLK_SETUP_SCRIPTSwas removed fromDEPENDENCIESand its*_GIT/*_REFsettings were deleted, but the install flow still expectsHLK_SETUP_SCRIPTS_DIRto be available when generatingoverride.install.json(seeconfig.sh, which reads${HLK_SETUP_SCRIPTS_DIR}). With this change,HLK_SETUP_SCRIPTS_DIRwill be unset/empty and the generated AutoHCK override will contain an invalidhck_setup_scripts_path.
Suggested fix: either re-add HLK_SETUP_SCRIPTS to DEPENDENCIES (and restore the variables) so install.sh populates HLK_SETUP_SCRIPTS_DIR, or update the config generation to stop referencing HLK_SETUP_SCRIPTS_DIR / remove that override field if AutoHCK no longer needs it.
DEPENDENCIES=(
VIRTIOFSD
QEMU
EXTRA_SOFTWARE
HLK_PLAYLISTS
HCK_FILTERS
AUTOHCK
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- EXTRA_SOFTWARE: 6fc4577 -> f92e660 - HCK_FILTERS: fdfeaa2 -> 364fa8e - AUTOHCK: v0.17.7 -> v0.18.0 - HLK_SETUP_SCRIPTS: drop Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
No description provided.