toolsHCK: remove UnloadPlaylist call#76
Conversation
Remove the UnloadPlaylist call as only one playlist is loaded per run, making it unnecessary. Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the playlist unloading logic from the createprojectpackage function in tools/toolsHCK.ps1. Feedback suggests that removing this cleanup step could lead to persistent state issues in the HLK database, causing subsequent commands to return unexpectedly filtered results when the script is used in a long-running server context.
I am having trouble creating individual review comments. Click here to see my feedback.
tools/toolsHCK.ps1 (2282-2290)
Removing the UnloadPlaylist call introduces persistent state changes to the project in the HLK database. Since toolsHCK.ps1 can operate as a long-running server (see the while($true) loop at line 2457), any playlist loaded during a createprojectpackage call will remain active for that project. This means subsequent commands on the same project—such as listtests or another createprojectpackage without a playlist—will unexpectedly return filtered results. If the goal is to ensure each command starts with a clean project state, this cleanup logic should be retained.
|
Resolves: HCK-CI/AutoHCK/issues/83 |
|
In general gemini correct, but in our case we can go with this |
2 participants
Remove the UnloadPlaylist call as only one playlist is loaded per run, making it unnecessary.