Fix sort/partition gradients for multidim arrays - #758
Open
imperatormk wants to merge 2 commits into
Open
Conversation
Contributor
|
This is an LLM generated commit created by an LLM agent? |
Author
|
Nope just LLM code by an LLM operated by a human! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both JVP and VJP were broken for arrays with ndim > 1. The JVP used g[sort_perm] which indexes axis 0 regardless of the sort axis, returning wrong shapes. The VJP just raised NotImplementedError.
Existing tests only covered 1D so this never came up.