Skip to content

fix(api): detect GPT-5 multimodal models #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panDing19 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): detect GPT-5 multimodal models #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ The format is based on Keep a Changelog, and this project currently tracks chang

### Fixed

- Multimodal model detection now recognizes OpenAI `gpt-4.1` and `gpt-5`
family model names, including `gpt-5.5`, so image inputs are sent natively
instead of being routed through the image-to-text fallback.
- Codex subscription requests now pass reasoning effort separately, enabling `gpt-5.5` with `xhigh` effort instead of treating `gpt-5.5 xhigh` as an unsupported model name.
- Telegram channel now delivers replies again under `ohmo init --no-interactive` and other configs that do not write a `reply_to_message` field. `TelegramConfig` declares `reply_to_message: bool = True` so the attribute access in `TelegramChannel.send` no longer raises `AttributeError` and outbound progress/tool-hint/final messages are sent as expected. See issue #243.

Expand Down
4 changes: 3 additions & 1 deletion src/openharness/api/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,10 @@ def auth_status(settings: Settings) -> str:
# Anthropic Claude 3+ (all Claude 3 and later support images)
re.compile(r"^claude-3(?:\.\d+)?(?:-sonnet|-opus|-haiku)?"),
re.compile(r"^claude-(?:sonnet|opus|haiku)-\d"),
# OpenAI GPT-4o / o-series
# OpenAI multimodal GPT / o-series
re.compile(r"^gpt-4\.1(?:$|[-.])"),
re.compile(r"^gpt-4o"),
re.compile(r"^gpt-5(?:$|[-.])"),
re.compile(r"^o[1349]-"),
# Google Gemini
re.compile(r"^gemini-(?:pro-)?vision"),
Expand Down
7 changes: 7 additions & 0 deletions tests/test_tools/test_image_to_text_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,14 @@
("claude-3-opus-20240229", True),
("claude-3-haiku-20240307", True),
# OpenAI multimodal
("gpt-4.1", True),
("gpt-4.1-mini", True),
("gpt-4o", True),
("gpt-4o-mini", True),
("gpt-5", True),
("gpt-5.4", True),
("gpt-5.5", True),
("gpt-5.5 xhigh", True),
("o1-mini", True),
("o3-mini", True),
("o4-mini", True),
Expand Down Expand Up @@ -64,6 +70,7 @@
("", False),
# With provider prefix
("anthropic/claude-sonnet-4-6", True),
("openai/gpt-5.5", True),
("openai/gpt-4o", True),
("openai/gpt-4", False),
],
Expand Down