Skip to content

fix(mcp): add debug/warning logging for server connection attempts and failures #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sridhar-3009 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mcp): add debug/warning logging for server connection attempts and failures #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/openharness/mcp/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import asyncio
import contextlib
import logging
from contextlib import AsyncExitStack
from typing import Any

Expand All @@ -21,6 +22,8 @@
McpToolInfo,
)

log = logging.getLogger(__name__)


class McpServerNotConnectedError(Exception):
"""Raised when an MCP server is not connected or its session has been lost."""
Expand All @@ -45,18 +48,33 @@ def __init__(self, server_configs: dict[str, object]) -> None:
async def connect_all(self) -> None:
"""Connect all configured MCP servers supported by the current build."""
for name, config in self._server_configs.items():
transport = getattr(config, "type", "unknown")
log.debug("MCP: connecting to server %r (transport=%s)", name, transport)
if isinstance(config, McpStdioServerConfig):
await self._connect_stdio(name, config)
elif isinstance(config, McpHttpServerConfig):
await self._connect_http(name, config)
else:
detail = f"Unsupported MCP transport in current build: {config.type}"
log.warning("MCP: server %r skipped — %s", name, detail)
self._statuses[name] = McpConnectionStatus(
name=name,
state="failed",
transport=config.type,
auth_configured=bool(getattr(config, "headers", None)),
detail=f"Unsupported MCP transport in current build: {config.type}",
detail=detail,
)
status = self._statuses.get(name)
if status:
if status.state == "connected":
log.debug(
"MCP: %r connected — %d tools, %d resources",
name,
len(status.tools),
len(status.resources),
)
elif status.state == "failed":
log.warning("MCP: %r failed to connect — %s", name, status.detail)

async def reconnect_all(self) -> None:
"""Reconnect all configured servers."""
Expand Down Expand Up @@ -178,6 +196,7 @@ async def read_resource(self, server_name: str, uri: str) -> str:
return "\n".join(parts).strip()

async def _connect_stdio(self, name: str, config: McpStdioServerConfig) -> None:
log.debug("MCP: spawning stdio process for %r: %s %s", name, config.command, " ".join(config.args))
stack = AsyncExitStack()
try:
read_stream, write_stream = await stack.enter_async_context(
Expand Down Expand Up @@ -216,6 +235,7 @@ async def _connect_stdio(self, name: str, config: McpStdioServerConfig) -> None:
)

async def _connect_http(self, name: str, config: McpHttpServerConfig) -> None:
log.debug("MCP: connecting to HTTP server %r at %s", name, config.url)
stack = AsyncExitStack()
try:
http_client = await stack.enter_async_context(
Expand Down