Disable the balance-check reporting in eCLM-ParFlow simulations - #125
Open
s-poll wants to merge 2 commits into
Open
Disable the balance-check reporting in eCLM-ParFlow simulations#125s-poll wants to merge 2 commits into
s-poll wants to merge 2 commits into
Conversation
avoid spamming in log file, thereby improve performance
Member
|
@s-poll this PR actually disables water & soil balance check routines in eCLM-ParFlow, no? I think the PR description & title should reflect this since this is the most important change; reduced logging is simply a side effect. |
kvrigor
requested changes
Aug 3, 2026
s-poll
changed the title
Member
Author
|
You are right, the check itself (not just its logging) is what is being skipped for COUP_OAS_PFL, I renamed the PR accordingly. |
kvrigor
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppresses excessive logging output of balance check errors / nan warnings during eCLM-ParFlow simulations to keep log sizes manageable and improve performance.
Long-term integration:
In the long run, this should incorporate or align with #80 or even better include an accurate balance check