-
Notifications
You must be signed in to change notification settings - Fork 76
Update angular to v20 #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
No idea why this works locally but not here... To be continued. |
|
I ran into the same SSH error while testing this branch: Looks like the dependency is being pulled via SSH, which fails without GitHub SSH access. Would switching to an HTTPS Git URL or publishing a version to npm help make installs more contributor-friendly? |
|
That's a good idea - I think there are forks of `cypress-plugin-snapshot`
which are on npm. Or indeed, probably https might work. What I don't
understand is what changed to break this? But the main thing is to get it
working again.
…On Wed, 29 Oct 2025 at 11:31, NikhilSharma201 ***@***.***> wrote:
*NikhilSharma201* left a comment (HSF/phoenix#729)
<#729 (comment)>
I ran into the same SSH error while testing this branch:
***@***.******@***.***/meinaart/cypress-plugin-snapshots.git
Fatal Error: Could not read from remote repository.
Looks like the dependency is being pulled via SSH, which fails without
GitHub SSH access. Would switching to an HTTPS Git URL or publishing a
version to npm help make installs more contributor-friendly?
—
Reply to this email directly, view it on GitHub
<#729 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTTQSLQ2YWTHI7JDLCPZS332CJO7AVCNFSM6AAAAACKPTSBQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINRQHAYDCNRXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Got it, happy to help test any workaround or patch once it's ready. Let me know if you'd like me to try a fork or alternate setup. |
ffe65dd to
9c5a7bc
Compare
…stic EventEmitter - Created framework-independent EventEmitter class to replace Angular's EventEmitter - Removed Angular dependency from phoenix-event-display library - Fixed Jest configuration (jest.conf.js -> jest.conf.cjs, corrected setup paths) - Added comprehensive mocks for three.js ESM examples to resolve test issues - Created test suite for EventEmitter with full coverage - All tests now passing (345/345 tests, 83/83 test suites) This change makes phoenix-event-display truly framework-agnostic and improves the library's architecture by removing the Angular framework dependency.
feat(event-display): Remove Angular dependency from phoenix-event-display and fix phoenix-ng test infrastructure
|
Locally at least, this still seems to be failing with: |
|
Hi @EdwardMoyse I’d like to work on this issue.
Please let me know if there are any specific tasks I should start with. |
|
@deveshbervar that would be amazing. Feel free to trash this MR and start again if you prefer. I'll assign the related issue to you. |
|
Thanks a lot for the invite, @EdwardMoyse! |
Unfortunately this does not work yet.
When I do
yarn startI getbut opening here in case anyone has any ideas what I need to change?
cc @9inpachi @sponce @AlphaAbdo @DamianArado