feat(frontend): add command palette & S+F keybind - #793
Conversation
Dokploy Preview Deployment
|
Sanielia
left a comment
Sanielia
left a comment
There was a problem hiding this comment.
How is user supposed to know that we have such feature? Maybe add something like github Type / to search?
I get
Warning: `DialogContent` requires a `DialogTitle` for the component to be accessible for screen reader users.
If you want to hide the `DialogTitle`, you can wrap it with our VisuallyHidden component.
For more information, see https://www.reka-ui.com/docs/components/dialog.html#title [utils.ts:35:15](http://localhost:3000/_nuxt/@fs/home/kubaryt/Documents/Gits/Hack4KrakSite/node_modules/reka-ui/src/Dialog/utils.ts)
Warning: Missing `Description` or `aria-describedby="undefined"` for DialogContent.
when opening the command palette
Norbiros
left a comment
Norbiros
left a comment
There was a problem hiding this comment.
This needs to optimized and tested. If I'm not mistaken, with your code if you open https://hack4krak.pl you are always fetching tasks. I think a very small percentage of users is going to use this feature, so we don't need to prefetch.
|
I also switched icons to pixelart |
lajczi
changed the title
S + F keybind
lajczi
changed the title
S + F keybindS+F keybind
3de0353 to
dca47dd
Compare
Sanielia
left a comment
Sanielia
left a comment
There was a problem hiding this comment.
- this form looks ugly, mainly padding is too big
- I think there should be an option to collapse cateogry in command pallette, like i don't wanna scroll all tasks each team
- when you open and then close command pallette you seem to be focused on search field so clicking / or s+f doesn't do anything and you need to click somewhere where this focus will change
Sanielia
left a comment
Sanielia
left a comment
There was a problem hiding this comment.
All categories should be collapsable
Signed-off-by: lajczi <lajczi@disroot.org>
Signed-off-by: lajczi <lajczi@disroot.org>
Signed-off-by: lajczi <lajczi@disroot.org>
Signed-off-by: lajczi <lajczi@disroot.org>
Signed-off-by: lajczi <lajczi@disroot.org>
Signed-off-by: lajczi <lajczi@disroot.org>
Signed-off-by: lajczi <lajczi@disroot.org>
|
i guess this pr is ready. Ignore ci errors, they are unrelated |
|
for the love of god just rebase this branch on master, ci errors should be fixed by this as well |
|
or not, because they are indeed related, those are errors caused by comopnents you introduced |
|
it mostly looks good, however i cannot remove the ui without you fixing this import errror because it breaks entire commandpallette |
|
imagine merging this pr with "Create a merge commit" option |
Sanielia
left a comment
Sanielia
left a comment
There was a problem hiding this comment.
Currently number of tasks displayed at once is a bit arbitrary, i think we shouldn't cap it, because if you want to find specific task you will search it up, maybe just show only tasks that you didn't complete yet, however don't cap number of displayed tasks. Completed tasks should be still searcheable tho
|
btw this pr will also fix CI on master (I mean lint) |
|
all requested changes done. let's finally get this merged pls |
3 participants
Closes #616 🎉
References:
Preview: (outdated)
