feat: add callback url support across pages by lajczi · Pull Request #800 · Hack4Krak/Hack4KrakSite

lajczi · 2026-03-01T17:57:24Z

Closes #455

Norbiros

Ideally it would be great to pass it to the backend while registering, include it in registration confirm link, but I don't think anybody cares about that, so just fix the issues mentioned below

Sanielia

there is no callback on account/submit_personal_information

lajczi · 2026-03-03T16:20:06Z

wtf

Sanielia · 2026-03-03T16:23:06Z

wtf

flaky CI

Norbiros

I'm a bit eppy, so I might be hallucinating/not seeing something, but how is that even supposed to work?

hack4krak-frontend-dokploy · 2026-03-08T16:32:19Z

Dokploy Preview Deployment

Name	Status	Preview	Updated (UTC)
Frontend	❌ Failed	Preview URL	2026-07-15T18:46:18.260Z

Sanielia

Also add callback coming back to /panel/profile in frontend/app/panel/profile.vue in Zmień lub zobacz informacje o końcie

          <UButton icon="mdi:account" variant="ghost" color="neutral" @click="navigateTo('/account/submit_personal_info')">
            Zmień lub zobacz informacje o koncie
          </UButton>

Signed-off-by: lajczi <lajczi@disroot.org>

…il_confirmation_success Consolidate duplicate test setup into the existing success test, adding the no-callback Refresh header assertion there instead of a separate test. https://claude.ai/code/session_013q6iJ5EWBJR6ZXAf3itbrd

Signed-off-by: lajczi <lajczi@disroot.org>

lajczi requested a review from a team as a code owner March 1, 2026 17:57

Sanielia previously approved these changes Mar 2, 2026

View reviewed changes

Norbiros requested changes Mar 2, 2026

View reviewed changes

Comment thread frontend/app/middleware/auth.global.ts Outdated

Comment thread frontend/app/middleware/auth.global.ts Outdated

Comment thread frontend/app/components/AuthForm.vue Outdated

lajczi dismissed Sanielia’s stale review via b2c3995 March 2, 2026 15:42

lajczi marked this pull request as draft March 2, 2026 15:58

lajczi marked this pull request as ready for review March 2, 2026 16:08

lajczi requested a review from a team as a code owner March 2, 2026 16:08

lajczi changed the title ~~feat(frontend): redirect to callback url after login~~ feat(frontend): redirect to callback url after login & registration Mar 2, 2026

Norbiros requested changes Mar 2, 2026

View reviewed changes

Comment thread backend/src/models/email_verification_request.rs

lajczi requested review from Norbiros and Sanielia March 2, 2026 16:34

Sanielia requested changes Mar 3, 2026

View reviewed changes

lajczi requested a review from Sanielia March 3, 2026 16:16

Sanielia previously approved these changes Mar 3, 2026

View reviewed changes

Norbiros requested changes Mar 8, 2026

View reviewed changes

Comment thread frontend/app/middleware/auth.global.ts Outdated

Comment thread backend/src/routes/auth/register.rs

lajczi dismissed Sanielia’s stale review via 8706a71 March 8, 2026 16:32

lajczi force-pushed the issue/455 branch from 5206638 to 8706a71 Compare March 8, 2026 16:32

lajczi requested review from Norbiros and Sanielia March 10, 2026 15:45

lajczi force-pushed the issue/455 branch from 31e11ec to 086dbb0 Compare March 21, 2026 18:13

Sanielia force-pushed the issue/455 branch from 086dbb0 to 21c903a Compare April 1, 2026 12:55

Sanielia requested changes Apr 1, 2026

View reviewed changes

Comment thread backend/src/routes/auth/register.rs Outdated

Comment thread frontend/app/middleware/auth.global.ts

Comment thread frontend/app/middleware/auth.global.ts

lajczi force-pushed the issue/455 branch from 21c903a to 797bc8a Compare April 1, 2026 13:18

lajczi changed the title ~~feat(frontend): redirect to callback url after login & registration~~ feat(frontend) add callback url support across pages Apr 1, 2026

lajczi requested a review from Sanielia April 1, 2026 13:29

Sanielia previously approved these changes Apr 1, 2026

View reviewed changes

Sanielia dismissed their stale review via c44ce39 April 4, 2026 14:30

lajczi added 2 commits April 19, 2026 14:28

chore(backend): add max length validation to callback

dd68d40

Signed-off-by: lajczi <lajczi@disroot.org>

feat: add callback url to submit_personal_info page

a140e36

Signed-off-by: lajczi <lajczi@disroot.org>

lajczi force-pushed the issue/455 branch from c44ce39 to a140e36 Compare April 19, 2026 12:29

lajczi added 2 commits April 19, 2026 15:01

Merge branch 'master' into issue/455

a87cbcb

test(backend): add additional test coverage for callback url

ff3c932

Signed-off-by: lajczi <lajczi@disroot.org>

lajczi requested a review from Norbiros April 19, 2026 13:30

lajczi changed the title ~~feat(frontend) add callback url support across pages~~ feat: add callback url support across pages Apr 19, 2026

lajczi closed this Apr 19, 2026

lajczi reopened this Apr 19, 2026

Sanielia requested changes Apr 21, 2026

View reviewed changes

Comment thread backend/src/utils/validation.rs Outdated

Comment thread backend/tests/routes/auth.rs Outdated

Comment thread frontend/app/components/AuthForm.vue Outdated

claude and others added 3 commits April 21, 2026 16:59

fix: add validation message and safe callback query cast

0504071

Signed-off-by: lajczi <lajczi@disroot.org>

...

55fb245

Signed-off-by: lajczi <lajczi@disroot.org>

lajczi commented Apr 21, 2026

View reviewed changes

Comment thread frontend/app/middleware/guest.ts Outdated

one last place

8729fec

Signed-off-by: lajczi <lajczi@disroot.org>

Sanielia previously approved these changes May 2, 2026

View reviewed changes

Comment thread backend/tests/routes/auth.rs

lajczi marked this pull request as draft May 6, 2026 12:23

Norbiros force-pushed the master branch from 94eedf5 to 0d5e9b7 Compare May 11, 2026 10:14

lajczi added 2 commits May 31, 2026 20:22

Merge origin/master into issue/455 and resolve auth callback conflicts

1bfa0cd

lol

9993644

lajczi dismissed Sanielia’s stale review via 9993644 May 31, 2026 18:31

lajczi added 5 commits May 31, 2026 20:36

revert: undo accidental TasksTemplate submodule update

c11bf36

chore: regen openapi and simplify auth confirmation test

6690366

revert: drop unintended auth test changes

e35ea7e

Merge branch 'master' into issue/455

3699375

regen openapi schema

baefdda

lajczi marked this pull request as ready for review May 31, 2026 18:45

lajczi requested a review from Sanielia May 31, 2026 18:45

Sanielia approved these changes Jun 3, 2026

View reviewed changes

Merge branch 'Hack4Krak:master' into issue/455

dc95e21

Uh oh!

Conversation

lajczi commented Mar 1, 2026

Uh oh!

Norbiros left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sanielia left a comment

Choose a reason for hiding this comment

Uh oh!

lajczi commented Mar 3, 2026

Uh oh!

Sanielia commented Mar 3, 2026

Uh oh!

Norbiros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hack4krak-frontend-dokploy Bot commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dokploy Preview Deployment

Uh oh!

Sanielia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Norbiros left a comment •

edited

Loading

hack4krak-frontend-dokploy Bot commented Mar 8, 2026 •

edited

Loading