feat(ci): configure unlighthouse in CI - #853
Conversation
| 'performance': 55, | ||
| 'accessibility': 80, | ||
| 'best-practices': 85, | ||
| 'seo': 80, |
There was a problem hiding this comment.
The point of adding Nuxt SEO was to monitor issues that hurt our rating. Those current limits are kinda low, so it won't catch most of our mistakes. I see 2 possible solutions to this problem:
- resolve issue related to
seo,best-practicesandaccessibilityon this PR, it will require mostly mindless work with addingalttags etc., and after you are finish bump up those values - let's merge this PR with lower limits, but create a new issue for impoving our scores & increasing the budget
There was a problem hiding this comment.
Done, there are two problems in Accesibility left to resolve to get all 100's. First is related to colors contrasts while the second one is caused by Auto-Form. With Auto-Form I can't do anythink while that first one I simply prefer don't to touch colors/design aspects.
There was a problem hiding this comment.
What about other fields like seo and best practices?
that first one I simply prefer don't to touch colors/design aspects.
Could you please rebase your branch on top of master and verify if it is happening again? Could you provide more information about this issue? If you don't want to touch any of that, I can quickly fix it and you can just rebase
There was a problem hiding this comment.
Rest fields (except performance) are 100's
"Background and foreground colors do not have a sufficient contrast ratio." - the muted text is not enough visable on the background
There was a problem hiding this comment.
What? They are 98:
'best-practices': 98, 'seo': 98,
There was a problem hiding this comment.
"Background and foreground colors do not have a sufficient contrast ratio." - the muted text is not enough visable on the background
Thanks for reporting! I just committed a fix for that eb066ce
There was a problem hiding this comment.
They are 100s but I set limits to 98. IDK if we want to be that strict but i can change it
5f77c56 to
56830f4
Compare
Dokploy Preview Deployment
|
fa64450 to
1fe0464
Compare
d90f501 to
8e845ca
Compare
5e191d8 to
49d1f47
Compare
49d1f47 to
290b6ae
Compare
There was a problem hiding this comment.
Is there a reason for this change, or am I missing something
| }, | ||
| ci: { | ||
| budget: { | ||
| 'performance': 55, |
There was a problem hiding this comment.
If we know that performance is unreliable, maybe you should completely disable it like this:
onlyCategories: ['best-practices', 'accessibility', 'seo'],
4 participants
closes #751