Skip to content

ITP-2026-1 | Roumaissae Bakkali Benali | Week 1 | 01- Wireframe to Web Code | 6:06PM#72

Open
Roumaissae0 wants to merge 6 commits intoHackYourFutureBelgium:mainfrom
Roumaissae0:feature/wireframe
Open

ITP-2026-1 | Roumaissae Bakkali Benali | Week 1 | 01- Wireframe to Web Code | 6:06PM#72
Roumaissae0 wants to merge 6 commits intoHackYourFutureBelgium:mainfrom
Roumaissae0:feature/wireframe

Conversation

@Roumaissae0
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

If I have an image saved locally but don't have a URL for it, is there any way to add it without a link?

(Make regular small commits in this new branch with clear messages.) I only make little commits.(small dots)
Explenations
adding <li> and changing img src
@fgsumer
Copy link

fgsumer commented Feb 24, 2026

You have good content 👍
But structurally, this does not meet the assignment requirements yet.

Can you update your code based on the feedback below, please?

  • All three topics (README, Wireframe, Branch) are inside one single . The assignment requires three unique articles such as
`<main>
  <article>README</article>
  <article>Wireframe</article>
  <article>Branch</article>
</main>`
  • You placed <li> directly inside <p> which is invalid HTML. List items must be inside <ul> or <ol>:
  • You need to update css file too. Even minimal styling is expected.
  • You made changes in contributing.md and created explaining_webpage.html which are not required in this task.

Be sure your assignment meets all the acceptance criteria described in README.md file.

@Roumaissae0
Copy link
Author

Roumaissae0 commented Feb 26, 2026

Hello Fatima,
Thank you for your time and your correction as well. How can I fix the changes that I made at the explaining webpage and the other one?
pd: I fixed the other errors

@fgsumer
Copy link

fgsumer commented Mar 4, 2026

This one is close, but there are a couple of improvements and HTML + CSS issues to fix.

  • Inside the header you used <div class="Normal_text"> for a paragraph. Better to use a real <p>
  • In the README and Wireframe articles, <li> items are without a <ul> or <ol> container. That’s invalid HTML.
  • Avoid <br>, split into 2 <p> if you want spacing.
  • The footer is missing left: 0; width: 100%; so it doesn't stretch across the page. Also add spacing body { padding-bottom: 80px; } so it doesn’t cover content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants