Skip to content

ITP-2026-1 | Michael English | Week 1 | Wireframe to Web Code#74

Open
Eigo-G wants to merge 5 commits intoHackYourFutureBelgium:mainfrom
Eigo-G:feature/wire
Open

ITP-2026-1 | Michael English | Week 1 | Wireframe to Web Code#74
Eigo-G wants to merge 5 commits intoHackYourFutureBelgium:mainfrom
Eigo-G:feature/wire

Conversation

@Eigo-G
Copy link

@Eigo-G Eigo-G commented Feb 20, 2026

Learners, PR Template

Self checklist

[x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[x] My changes meet the requirements of the task
[ ] I have tested my changes
[x] My changes follow the style guide

Changelist

Made Changes and followed coursework instructions to the best of my abilities.

Questions

I was unable to test using Lighthouse as there was an error message stating it wasn't a valid webpage. How do I properly test these projects? How frequently do you recommend making commits? I would make several changes before submitting one, is that okay?

@Eigo-G Eigo-G marked this pull request as draft February 20, 2026 20:01
@Eigo-G Eigo-G marked this pull request as ready for review February 20, 2026 20:02
@fgsumer
Copy link

fgsumer commented Feb 24, 2026

You’re very close 👍
Good structure and content.

Please fix these :

  1. You used:
<h1> (good)
<h2> (good)
<h3>
<h4>

This is not correct hierarchy for sibling articles. All three articles are at the same level, so they should all use:
<h2>
Correct structure:

<h1>Page Title</h1>
 <h2>Article 1</h2>
 <h2>Article 2</h2>
 <h2>Article 3</h2>
  1. You used <br> inside a paragraph for formatting. Better to split into two <p> elements instead of using <br>.
  2. Do not forget to run Lighthouse and fix any accessibility warnings.
  3. You need to update css file too. Even minimal styling is expected.

Be sure your assignment meets all the acceptance criteria described in README.md file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants