ITP-2026-1 | Roumaissae Bakkali Benali | Week 2 | Form-Controls

[Roumaissae0]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Developers must test their work.

Let's write out our testable criteria. Check each one off as you complete it.

• I have used HTML only.
• I have not used any CSS or JavaScript.

HTML

• My form is semantic html.
• All inputs have associated labels.
• My Lighthouse Accessibility score is 100.
• I require a valid name. I have defined a valid name as a text string of two characters or more.
• I require a valid email.
• I require one colour from a defined set of 3 colours.
• I require one size from a defined set of 6 sizes.
  Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[talmurshidi]

@Roumaissae0 , Good effort submitting your work and creating the form. The basic structure is there, and you are making progress with using Git and pull requests.

Feedback

Your submission does not fully meet the assignment requirements and needs several corrections.

1. HTML-only requirement not respected
The assignment clearly requires HTML only, but your solution includes JavaScript (<script> and onclick). Validation must be done using HTML attributes such as required, type="email", and minlength="2". The JavaScript code must be removed.

2. Semantic HTML requirement not fully met
The form should use semantic HTML structure. While you included some structural elements, the form itself should be better organized using semantic elements such as:

• <header>

• <main>

• <form>

• <fieldset>

• <legend>

Using <fieldset> and <legend> is important because they group related inputs and improve accessibility. This is required for the criterion "My form is semantic html."

3. Validation requirements incomplete

Some validation requirements from the assignment description are missing:

• The name field must require at least two characters. Currently it is only marked as required. You should add:

  minlength="2"

4. Pull Request contains unrelated changes

Your pull request includes changes to contributing.md, which is not part of this assignment. Only the assignment file (index.html) should be included. Adding unrelated files makes the review more difficult and does not follow the instructions.

5. Development history is too limited

The pull request contains very few commits, so it does not clearly show your development process. You should make several small commits while working, at least 4 meaningful commits (for example: structure, inputs, validation, testing).

---

What to improve

• Remove all JavaScript

• Use proper semantic HTML, including <fieldset> and <legend>

• Add minlength="2" to the name field

• Include only assignment files in the pull request

• Make clearer commits showing your progress

[Roumaissae0]

Hello Tamer,
Thank you for your time and your correction as well. The point 4 I don't understand exactly how to remove the other file .

[talmurshidi]

Hello @Roumaissae0
You're very welcome, it's to restore the file or revert the commit (I think it's not easy). You can consider it as a recommendation for the next assignments.

[Roumaissae0]

Okay I will try and if doesn't work I'm gonna tell you Sunday , thank you .

[talmurshidi]

How to Remove an Unrelated File (e.g. Form-Controls/README.md) From Your PR
(When the file already exists in main, and you edited it by mistake in your branch)
We are not deleting the file.
We are simply restoring it to the exact version that exists in main.
When you do this correctly, the file will disappear from the PR changes automatically.

Using Terminal in VS Code
Step 1 --- Make sure you are on your assignment branch
In VS Code terminal:

git branch

You should see, for example:

* form-controls

If not, switch to it:

git checkout your-branch-name

Step 2 --- Fetch the latest main
This makes sure your local repo knows the latest version of main.

git fetch origin

No changes happen yet. This just updates references.

Step 3 --- Restore the file from main
Now we tell Git:

"Replace my current version of this file with the version from origin/main."

git restore --source=origin/main -- Form-Controls/README.md

What this does:

• It copies the README from main
• It overwrites your edited version in your branch
• It stages it as a change

Step 4 --- Commit the fix

git add Form-Controls/README.md
git commit -m "Revert README changes (not part of assignment)"

Step 5 --- Push

git push

Now refresh your PR on GitHub.
The README file should disappear from "Files changed".

[Roumaissae0]

Okey I understand now .Thank you so much for your time .