Skip to content

Brussel | ITP-2026-1 | James Ishimwe | Week 1 | Wireframe to Web Code#87

Open
jamesishimwe wants to merge 24 commits intoHackYourFutureBelgium:mainfrom
jamesishimwe:feature/wireframe
Open

Brussel | ITP-2026-1 | James Ishimwe | Week 1 | Wireframe to Web Code#87
jamesishimwe wants to merge 24 commits intoHackYourFutureBelgium:mainfrom
jamesishimwe:feature/wireframe

Conversation

@jamesishimwe
Copy link

Brussel | ITP-2026-1 | James Ishimwe | Week 1 | Wireframe to Web Code

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Improved heading title and description for clarity then updated the page structure by adding a featured article section and a new articles section with two placeholder articles.

@fgsumer
Copy link

fgsumer commented Feb 26, 2026

Your assignment is not finished yet.

Please read the instructions carefully and be sure your assignment meets all the acceptance criteria described in README.md file.

@jamesishimwe
Copy link
Author

@fgsumer After reading carefully the instructions, I did some improvements. Please review my code again. Thank you.

@fgsumer
Copy link

fgsumer commented Mar 4, 2026

You have a strong start: semantic tags are used properly and the layout matches the wireframe nicely. ✅

Please fix these :

  1. bottom: 0 for footer does nothing unless you set a position (fixed or absolute) and you need to prevent overlap of footer.

--paper: oklch(7 0 0) is near black
--ink is mixed with black and --color isn’t defined
  1. You created 3 additional pages for each article and linked them like:

<a href="../wireframe-html.html">Read more</a>

This is not required by the assignment. It just asks for three articles with a link, not extra pages. Better approach :
- Use external links (GitHub docs, etc.) OR
- If you really want extra pages, they should: be in the same project structure (no ../)and reuse the same style.css (no inline <style>)

A reminder : I noticed that this PR contains too many commits, some of which may be unnecessary or could be better organized. Keeping your commit history clean is just as important as writing clean code.

add link html files to index

add title and text

add title and text

add title and text

add footer

add footer

add footer

add css

add css

add css to header
@jamesishimwe
Copy link
Author

@fgsumer I made the changes as you requested. I removed bottom:0 then changed --paper to white,removed black from ink then I defined color. I removed the unnecessary pages then I used external links. I also removed some unnecessary commits.
changes:

  1. Removed bottom:0 from footer in style.css
  2. Changed --paper to white,removed black from ink then I defined color
  3. Removed the unnecessary pages then I used external links
  4. Removed some unnecessary commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants