Brussel | ITP-2026-1 | James Ishimwe | Week 1 | Wireframe to Web Code#87
Brussel | ITP-2026-1 | James Ishimwe | Week 1 | Wireframe to Web Code#87jamesishimwe wants to merge 24 commits intoHackYourFutureBelgium:mainfrom
Conversation
|
Your assignment is not finished yet. Please read the instructions carefully and be sure your assignment meets all the acceptance criteria described in README.md file. |
|
@fgsumer After reading carefully the instructions, I did some improvements. Please review my code again. Thank you. |
|
You have a strong start: semantic tags are used properly and the layout matches the wireframe nicely. ✅ Please fix these :
This is not required by the assignment. It just asks for three articles with a link, not extra pages. Better approach : A reminder : I noticed that this PR contains too many commits, some of which may be unnecessary or could be better organized. Keeping your commit history clean is just as important as writing clean code. |
add link html files to index add title and text add title and text add title and text add footer add footer add footer add css add css add css to header
6f5114f to
2d74bf0
Compare
|
@fgsumer I made the changes as you requested. I removed bottom:0 then changed --paper to white,removed black from ink then I defined color. I removed the unnecessary pages then I used external links. I also removed some unnecessary commits.
|
Brussel | ITP-2026-1 | James Ishimwe | Week 1 | Wireframe to Web Code
Self checklist
Improved heading title and description for clarity then updated the page structure by adding a featured article section and a new articles section with two placeholder articles.