#1077: Added support of Python3 on top of Python 2.7#1078
Open
jfthuong wants to merge 2 commits intoHaikuTeam:masterfrom
Open
#1077: Added support of Python3 on top of Python 2.7#1078jfthuong wants to merge 2 commits intoHaikuTeam:masterfrom
jfthuong wants to merge 2 commits intoHaikuTeam:masterfrom
Conversation
Author
|
Python2 is still needed for the current version of |
andrewnc
approved these changes
May 13, 2022
andrewnc
left a comment
andrewnc
left a comment
There was a problem hiding this comment.
This changes all look good to me! Have you been able to test pushing with them?
|
|
||
| # Install git | ||
| choco install git python2 -y | ||
| choco install git python -y |
There was a problem hiding this comment.
should include a winget json for most windows environments, not everyone has choco, for linux and mac with homebrew you can include a brewfile, hate having to use requirements that don't match up in a readme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Regressions to look for:
Completed checkin tasks:
changelog/public/latest.json.