Repository navigation
perf: accelerate large INSERT selection and MOVE/COPY with fixed raster previews - #2065
Draft
gianlucafiore wants to merge 62 commits into
Draft
gianlucafiore wants to merge 62 commits into
gianlucafiore wants to merge 62 commits into
Conversation
gianlucafiore
changed the title
gianlucafiore
changed the title
gianlucafiore
changed the title
…equent MOVE/COPY previews
…ut expanding nested prototypes
gianlucafiore
changed the title
…hanging CAD behavior
… selection instead of empty outline
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance optimizations (DRAFT)
Latest diagnosis and correction (Oct 24)
Latest user PERF: 13,608-block crossing selection: candidates 57.5ms, hit 48ms, apply 10.9ms (large selection improvement). MOVE still:
command-raster-setup selected=13608 wires=82419 active=falseand each frame full-scenedirect-overlay=falsewith 82,421 wires. Themass-preview-rejectlogs were absent, meaning the capture likely failed downstream. Corrected raster extent handling:solid_f64-derived extent outlines can have sentinel cached AABBs, so derive bounds from outline vertices when AABB is invalid. Added explicitraster-rejectlogs for missing extent, invalid bounds, or zero segments.NOT YET VERIFIED: compilation and visual performance on user DWG pending. Draft, do not merge. No dynamic-block changes.