Manual camera controls using right analog stick#183
Merged
KiritoDv merged 9 commits intoMay 28, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of the manual camera mode implementation from the sm64plus project, adding settings to the enhancements menu. I don't know the rules regarding code taken from other ports/projects but since I found nothing explicitly against it I figured it was fine.
I've never really played SM64, but adding this functionality to Ghostship felt like a good opportunity for me to finally play this game, so I might not be the best person to say that this manual camera control implementation lives up to this port's vision and code quality control.
Most of the work in this PR was done by me, and I used Claude to fix two bugs introduced with this functionality port: a "jerking" motion bug in
mode_custom_camera()when switching directions with the manual camera mode on; and the camera getting stuck to walls on tight places.Addresses the open issue: #113